phantop/doukutsu-rs
1
0
Fork 0
mirror of https://github.com/doukutsu-rs/doukutsu-rs synced 2025-01-30 22:27:00 +00:00
Code Issues Releases Wiki Activity

Detect controllers from SDL_GameControllerDB correctly (#280)

Browse source 
SDL generates ControllerDeviceAdded events for controllers that are
already plugged in at the start of the game, but only if those are
recognized as game controllers at the time that we run SDL_Init.
Unfortunately, rust-sdl2 requires initializing SDL before we can call
load_mappings_from_read.

doukutsu-rs ships with this nice gamecontrollerdb.txt file built-into
the binary and loads it at startup, but previously it would not work for
controllers already plugged in before the game started because of the
above. This change works around the ordering issues between recognizing
devices as game controllers and event generation. Instead of using the
ControllerDeviceAdded events, we now use JoyDeviceAdded events. We still
check that the device is a supported game controller, and if it's not
supported then we skip it.
This commit is contained in:
Jordan Christiansen 2024-10-22 10:14:00 -05:00 committed by GitHub
parent 2ef34fe6f8
commit 97d85aa841
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/framework/backend_sdl2.rs
View file

@ -332,7 +332,7 @@ impl BackendEventLoop for SDL2EventLoop {
ctx.keyboard_context.set_key(drs_scan, false);
}
}
Event::ControllerDeviceAdded { which, .. } => {
Event::JoyDeviceAdded { which, .. } => {
let game_controller = &self.refs.borrow().game_controller;
if game_controller.is_game_controller(which) {