phantop/doukutsu-rs
1
0
Fork 0
mirror of https://github.com/doukutsu-rs/doukutsu-rs synced 2024-12-04 19:03:28 +00:00
Code Issues Releases Wiki Activity

fix a stupid mistake that could cause UB

Browse source
This commit is contained in:
Alula 2020-12-27 22:17:00 +01:00
parent b89fea9756
commit 81a422502c
No known key found for this signature in database
GPG key ID: 3E00485503A1D8BA
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/npc/list.rs
View file

@ -11,8 +11,9 @@ const NPC_LIST_MAX_CAP: usize = 512;
/// A data structure for storing an NPC list for current stage.
/// Provides multiple mutable references to NPC objects with internal sanity checks and lifetime bounds.
pub struct NPCList {
// UnsafeCell lets us break the pointer aliasing rules without undefined behavior.
npcs: UnsafeCell<Box<[NPC; NPC_LIST_MAX_CAP]>>,
// UnsafeCell is required because we do mutable aliasing (ik, discouraged), prevents Rust/LLVM
// from theoretically performing some optimizations that might break the code.
npcs: Box<UnsafeCell<[NPC; NPC_LIST_MAX_CAP]>>,
max_npc: Cell<u16>,
}
@ -20,7 +21,7 @@ pub struct NPCList {
impl NPCList {
pub fn new() -> NPCList {
let map = NPCList {
npcs: UnsafeCell::new(Box::new(unsafe {
npcs: Box::new(UnsafeCell::new(unsafe {
let mut parts_uninit: [NPC; NPC_LIST_MAX_CAP] = MaybeUninit::uninit().assume_init();
for part in parts_uninit.iter_mut() {