oko/kiafumi
2
0
Fork 0
Code Issues 8 Pull requests Projects 1 Releases Wiki Activity

SettingCommand does not check for permissions #8

New issue
Closed
opened 2022-03-29 12:32:41 +00:00 by oko · 4 comments
oko commented 2022-03-29 12:32:41 +00:00
Owner
Copy link

Anyone can change any value on the settings commands. This is obviously a security issue.

Anyone can change any value on the settings commands. This is obviously a security issue.
oko added the
bug
help wanted
 labels 2022-03-29 12:32:41 +00:00
Laika commented 2022-03-29 15:36:45 +00:00
Copy link

Curious as to what permission would be designated as the one to determine whether or not you could utilize that command. I could always make a setting to designate an administrator role.

Curious as to what permission would be designated as the one to determine whether or not you could utilize that command. I could always make a setting to designate an administrator role.
oko commented 2022-03-29 17:19:49 +00:00
Author
Owner
Copy link

I think the safest route is just requiring admin. I would hope the one adding the bot is smart enough to properly configure it anyways, right?

I think the safest route is just requiring admin. I would hope the one adding the bot is smart enough to properly configure it anyways, right?
Laika commented 2022-03-29 20:50:01 +00:00
Copy link

Figures, i'll have it require admin momentarily.

Figures, i'll have it require admin momentarily.
Laika commented 2022-03-29 20:55:00 +00:00
Copy link

done

done
Laika closed this issue 2022-03-29 20:55:00 +00:00
Laika added this to the Kiafumi Functionality project 2022-04-04 07:32:43 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
python
No results found.
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
perpetual

   
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
perpetual
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Kiafumi Functionality
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: oko/kiafumi#8
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?