mirror of
https://github.com/diamondburned/arikawa.git
synced 2024-12-03 20:32:55 +00:00
diamondburned
29582d6131
This commit changes the existing Plumb behavior to allow normal commands
to coexist along a plumbed command. This change allows certain behaviors
that would otherwise require manually switching on arguments.
An example use case of this change would be having a default behavior
when a subcommand call doesn't have a command name. For example, given
this code:
func (b *Banana) Setup(sub *bot.Subcommand) { sub.SetPlumb(b.Help) }
func (b *Banana) Green(*gateway.MessageCreateEvent) {}
func (b *Banana) Help(*gateway.MessageCreateEvent) {}
The subcommand "banana" could have its own help when it's called as
"!banana", while "!banana green" would trigger another handler.
|
||
|---|---|---|
| .. | ||
| extras | ||
| arguments.go | ||
| arguments_test.go | ||
| command.go | ||
| ctx.go | ||
| ctx_call.go | ||
| ctx_plumb_test.go | ||
| ctx_test.go | ||
| error.go | ||
| error_test.go | ||
| README.md | ||
| subcommand.go | ||
| subcommand_test.go | ||
What are the performance impacts of this library?
Not a lot for a Discord bot:
THIS IS OUTDATED. TODO: UPDATE.
# Cold functions, or functions that are called once in runtime:
BenchmarkConstructor-8 150537 7617 ns/op
BenchmarkSubcommandConstructor-8 155068 7721 ns/op
# Hot functions, or functions that can be called multiple times:
BenchmarkCall-8 1000000 1194 ns/op
BenchmarkHelp-8 1751619 680 ns/op
# Hot functions, but called implicitly on non-message-create events:
BenchmarkReflectChannelID_1Level-8 10111023 113 ns/op
BenchmarkReflectChannelID_5Level-8 1872080 686 ns/op