cowarin/Funkin
1
0
Fork 0
mirror of https://github.com/ninjamuffin99/Funkin.git synced 2025-03-21 01:19:26 +00:00
Code Issues Releases Wiki Activity

unhardcode notestyledropdown

Browse source
This commit is contained in:
lemz 2024-06-17 17:21:52 +02:00 committed by EliteMasterEric
parent 7a0c7ade35
commit fbcc73dcee
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
source/funkin/ui/debug/charting/util/ChartEditorDropdowns.hx
View file

@ -126,10 +126,7 @@ class ChartEditorDropdowns
{ {
dropDown.dataSource.clear(); dropDown.dataSource.clear();
// hardcoding this because i dont want note kind styles to be shown as well var noteStyleIds:Array<String> = NoteStyleRegistry.instance.listEntryIds();
// there is probably a better solution
// var noteStyleIds:Array<String> = NoteStyleRegistry.instance.listEntryIds();
var noteStyleIds:Array<String> = ['funkin', 'pixel'];
var returnValue:DropDownEntry = {id: "funkin", text: "Funkin'"}; var returnValue:DropDownEntry = {id: "funkin", text: "Funkin'"};
@ -138,6 +135,14 @@ class ChartEditorDropdowns
var noteStyle:Null<NoteStyle> = NoteStyleRegistry.instance.fetchEntry(noteStyleId); var noteStyle:Null<NoteStyle> = NoteStyleRegistry.instance.fetchEntry(noteStyleId);
if (noteStyle == null) continue; if (noteStyle == null) continue;
// check if the note style has all necessary assets (strums, notes, holdNotes)
if (noteStyle._data?.assets?.noteStrumline == null
|| noteStyle._data?.assets?.note == null
|| noteStyle._data?.assets?.holdNote == null)
{
continue;
}
var value = {id: noteStyleId, text: noteStyle.getName()}; var value = {id: noteStyleId, text: noteStyle.getName()};
if (startingStyleId == noteStyleId) returnValue = value; if (startingStyleId == noteStyleId) returnValue = value;