cowarin/Funkin
1
0
Fork 0
mirror of https://github.com/ninjamuffin99/Funkin.git synced 2024-12-04 04:33:24 +00:00
Code Issues Releases Wiki Activity

Fix crash on completing song after playtesting (#217)

Browse source 
Co-authored-by: Cameron Taylor <cameron.taylor.ninja@gmail.com>
This commit is contained in:
Eric 2023-11-20 11:27:58 -05:00 committed by GitHub
parent a1da5a5758
commit daf1ba85dc
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
source/funkin/ui/debug/charting/ChartEditorState.hx
View file

@ -4515,6 +4515,7 @@ class ChartEditorState extends HaxeUIState
/** /**
* Fix the current scroll position after exiting the PlayState used when testing. * Fix the current scroll position after exiting the PlayState used when testing.
*/ */
@:nullSafety(Off)
function resetConductorAfterTest(_:FlxSubState = null):Void function resetConductorAfterTest(_:FlxSubState = null):Void
{ {
moveSongToScrollPosition(); moveSongToScrollPosition();
@ -4526,7 +4527,11 @@ class ChartEditorState extends HaxeUIState
var instTargetVolume:Float = instVolumeSlider?.value ?? 1.0; var instTargetVolume:Float = instVolumeSlider?.value ?? 1.0;
var vocalTargetVolume:Float = vocalVolumeSlider?.value ?? 1.0; var vocalTargetVolume:Float = vocalVolumeSlider?.value ?? 1.0;
if (audioInstTrack != null) audioInstTrack.volume = instTargetVolume; if (audioInstTrack != null)
{
audioInstTrack.volume = instTargetVolume;
audioInstTrack.onComplete = null;
}
if (audioVocalTrackGroup != null) audioVocalTrackGroup.volume = vocalTargetVolume; if (audioVocalTrackGroup != null) audioVocalTrackGroup.volume = vocalTargetVolume;
} }