cowarin/Funkin
1
0
Fork 0
mirror of https://github.com/ninjamuffin99/Funkin.git synced 2025-11-25 21:55:55 +00:00
Code Issues Releases Wiki Activity

[BUGFIX] Ensure the variation used for the next song is valid.

Browse source 
When playing in story mode, `PlayState` assumes all the songs use the same variation, which is usually true, but not guaranteed. This PR makes `PlayState` use the `getFirstValidVariation` method to find the valid variation instead of using the `currentVariation` variable, which might not be valid.
This commit is contained in:
AppleHair 2024-07-17 18:00:07 +03:00 committed by EliteMasterEric
parent 68b7610225
commit bef2e98222
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
source/funkin/play/PlayState.hx
View file

@ -2912,7 +2912,7 @@ class PlayState extends MusicBeatSubState
{ {
targetSong: targetSong, targetSong: targetSong,
targetDifficulty: PlayStatePlaylist.campaignDifficulty, targetDifficulty: PlayStatePlaylist.campaignDifficulty,
targetVariation: currentVariation, targetVariation: targetSong.getFirstValidVariation(PlayStatePlaylist.campaignDifficulty),
cameraFollowPoint: cameraFollowPoint.getPosition(), cameraFollowPoint: cameraFollowPoint.getPosition(),
}); });
}); });
@ -2924,7 +2924,7 @@ class PlayState extends MusicBeatSubState
{ {
targetSong: targetSong, targetSong: targetSong,
targetDifficulty: PlayStatePlaylist.campaignDifficulty, targetDifficulty: PlayStatePlaylist.campaignDifficulty,
targetVariation: currentVariation, targetVariation: targetSong.getFirstValidVariation(PlayStatePlaylist.campaignDifficulty),
cameraFollowPoint: cameraFollowPoint.getPosition(), cameraFollowPoint: cameraFollowPoint.getPosition(),
}); });
} }