cowarin/Funkin
1
0
Fork 0
mirror of https://github.com/ninjamuffin99/Funkin.git synced 2024-11-05 06:14:36 +00:00
Code Issues Releases Wiki Activity

Merge pull request #487 from FunkinCrew/bugfix/lingering-hold-cover

Browse source 
Ensure playNoteHoldCover doesn't call if note is judged as 'miss'
This commit is contained in:
Cameron Taylor 2024-04-16 13:25:12 -04:00 committed by GitHub
parent b553dbd517 e6dc795d2a
commit b9a57b845e
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
source/funkin/play/PlayState.hx
View file

@ -2388,13 +2388,6 @@ class PlayState extends MusicBeatSubState
// Display the combo meter and add the calculation to the score. // Display the combo meter and add the calculation to the score.
popUpScore(note, event.score, event.judgement, event.healthChange); popUpScore(note, event.score, event.judgement, event.healthChange);
if (note.isHoldNote && note.holdNoteSprite != null)
{
playerStrumline.playNoteHoldCover(note.holdNoteSprite);
}
vocals.playerVolume = 1;
} }
/** /**
@ -2676,6 +2669,13 @@ class PlayState extends MusicBeatSubState
} }
comboPopUps.displayRating(daRating); comboPopUps.displayRating(daRating);
if (Highscore.tallies.combo >= 10 || Highscore.tallies.combo == 0) comboPopUps.displayCombo(Highscore.tallies.combo); if (Highscore.tallies.combo >= 10 || Highscore.tallies.combo == 0) comboPopUps.displayCombo(Highscore.tallies.combo);
if (daNote.isHoldNote && daNote.holdNoteSprite != null)
{
playerStrumline.playNoteHoldCover(daNote.holdNoteSprite);
}
vocals.playerVolume = 1;
} }
/** /**