Emi
/
PronounsToday
2
1
Fork 0
Code Issues 9 Pull Requests 2 Releases Activity

Better Vectored Write #4

Manually merged
sashanoraa merged 2 commits from write-all-vectored into convert-http-to-saml 2021-11-05 19:39:54 +00:00
Conversation 0 Commits 2 Files Changed 2 +111 -9
sashanoraa commented 2021-11-04 00:34:15 +00:00
Collaborator
Copy Link

I've create my own write_all_vectored impl in lue of the offical one being stable. This should preform better than just writing in a loop. I'm faily confident the code is safe after running tests with miri and examining the assembly output of the function.

I've create my own write_all_vectored impl in lue of the offical one being stable. This should preform better than just writing in a loop. I'm faily confident the code is safe after running tests with miri and examining the assembly output of the function.
sashanoraa added 2 commits 2021-11-04 00:34:15 +00:00
63cfa014d5 [web] use actual vectored write 
Since IoSlice::advance isn't stable I had to hack my own. I will need to
confirm that my implementation is safe.

Signed-off-by: Ben Aaron Goldberg <ben@benaaron.dev>
3a4afbcaea [web] confirm safety of advance 
After further testing and checks I'm fairy confident that the vectored
write code is safe.

Signed-off-by: Ben Aaron Goldberg <ben@benaaron.dev>
sashanoraa manually merged commit 3a4afbcaea into convert-http-to-saml 2021-11-05 19:39:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Emi/PronounsToday#4
No description provided.
Delete Branch "write-all-vectored"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?