Emi/PronounsToday
2
1
Fork 0
Code Issues 9 Pull requests 2 Releases Activity

[web] Statics dumpy??? #2

Open
Emi wants to merge 1 commit from dump-statics into main
pull from: dump-statics
merge into: Emi:main
Conversation 2 Commits 1 Files changed 3 +70 -4
Emi commented 2021-10-30 19:20:57 +00:00
Owner
Copy link
  • Implement pronouns-today dump-statics [path]
  • Defaults to ./static/
  • Should handle most common error cases pretty well
  • I made a whole branch for this 'cause I thought it would be more work, but now I'm committed
- Implement `pronouns-today dump-statics [path]` - Defaults to `./static/` - Should handle most common error cases pretty well - I made a whole branch for this 'cause I thought it would be more work, but now I'm committed
Emi requested review from sashanoraa 2021-10-30 19:21:07 +00:00
sashanoraa reviewed 2021-11-02 17:08:19 +00:00
web/src/statics.rs
@ -52,0 +82,4 @@
.map_err(|e| (e, path))
)
.collect::<Result<(), (io::Error, PathBuf)>>()
}
sashanoraa commented 2021-11-02 17:08:19 +00:00
Collaborator
Copy link

I think this might be cleaner with a for loop instead of 2 iterators but it's fine if you prefer this way.

I think this might be cleaner with a for loop instead of 2 iterators but it's fine if you prefer this way.
Emi commented 2021-11-05 20:14:39 +00:00
Author
Owner
Copy link

The problem with a for loop is that we want to make sure that there are no conflicts before we start to write out files. If we used a for loop, it already would've written several files before it noticed the conflict. By using disjoint interators, we can create a "checkpoint" and make sure there are no errors first

The problem with a for loop is that we want to make sure that there are no conflicts before we start to write out files. If we used a for loop, it already would've written several files before it noticed the conflict. By using disjoint interators, we can create a "checkpoint" and make sure there are no errors first
theotheroracle commented 2021-11-03 18:40:01 +00:00
Collaborator
Copy link

they got the dumpy tho

they got the dumpy tho
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dump-statics:dump-statics
git switch dump-statics

Merge

Merge the changes and update on Forgejo.
git switch main
git merge --no-ff dump-statics
git switch dump-statics
git rebase main
git switch main
git merge --ff-only dump-statics
git switch dump-statics
git rebase main
git switch main
git merge --no-ff dump-statics
git switch main
git merge --squash dump-statics
git switch main
git merge --ff-only dump-statics
git switch main
git merge dump-statics
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
sashanoraa
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Emi/PronounsToday!2
No description provided.