[web] Statics dumpy??? #2

Open
Emi wants to merge 1 commit from dump-statics into main
Owner
  • Implement pronouns-today dump-statics [path]
  • Defaults to ./static/
  • Should handle most common error cases pretty well
  • I made a whole branch for this 'cause I thought it would be more work, but now I'm committed
- Implement `pronouns-today dump-statics [path]` - Defaults to `./static/` - Should handle most common error cases pretty well - I made a whole branch for this 'cause I thought it would be more work, but now I'm committed
Emi added 1 commit 2021-10-30 19:20:58 +00:00
Emi requested review from sashanoraa 2021-10-30 19:21:07 +00:00
sashanoraa reviewed 2021-11-02 17:08:19 +00:00
@ -52,0 +82,4 @@
.map_err(|e| (e, path))
)
.collect::<Result<(), (io::Error, PathBuf)>>()
}
Collaborator

I think this might be cleaner with a for loop instead of 2 iterators but it's fine if you prefer this way.

I think this might be cleaner with a for loop instead of 2 iterators but it's fine if you prefer this way.
Author
Owner

The problem with a for loop is that we want to make sure that there are no conflicts before we start to write out files. If we used a for loop, it already would've written several files before it noticed the conflict. By using disjoint interators, we can create a "checkpoint" and make sure there are no errors first

The problem with a for loop is that we want to make sure that there are no conflicts before we start to write out files. If we used a for loop, it already would've written several files before it noticed the conflict. By using disjoint interators, we can create a "checkpoint" and make sure there are no errors first
Collaborator

they got the dumpy tho

they got the dumpy tho
This pull request can be merged automatically.
You are not authorized to merge this pull request.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin dump-statics:dump-statics
git checkout dump-statics

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff dump-statics
git checkout main
git merge --ff-only dump-statics
git checkout dump-statics
git rebase main
git checkout main
git merge --no-ff dump-statics
git checkout main
git merge --squash dump-statics
git checkout main
git merge --ff-only dump-statics
git checkout main
git merge dump-statics
git push origin main
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Emi/PronounsToday#2
No description provided.