From f03401915d7b4e42c0835dbd9e2241b75f2bb2c4 Mon Sep 17 00:00:00 2001 From: Edward Stuckey Date: Sun, 8 Dec 2024 11:52:58 -0500 Subject: [PATCH] Fix unlabeled element errors in live debugger (#284) [ci skip] IMGUI considers this a hard-exception now, so we need at least some form label, even if it is unused and hidden. Also fixed various "Unused" warnings --- src/live_debugger/mod.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/live_debugger/mod.rs b/src/live_debugger/mod.rs index 2a56016..2ef928b 100644 --- a/src/live_debugger/mod.rs +++ b/src/live_debugger/mod.rs @@ -1,4 +1,4 @@ -use imgui::{CollapsingHeader, Condition, ImStr, ImString, Slider, Window}; +use imgui::{CollapsingHeader, Condition, ImStr, ImString}; use itertools::Itertools; use crate::framework::context::Context; @@ -95,7 +95,7 @@ impl LiveDebugger { self.command_line_focused = true; } - ui.input_text("", &mut self.command_line_parser.buffer).build(); + ui.input_text("##I", &mut self.command_line_parser.buffer).build(); } if ui.is_item_active() { @@ -173,7 +173,7 @@ impl LiveDebugger { ui.text(format!("Game speed ({:.1} TPS):", state.current_tps())); let mut speed = state.settings.speed; - ui.slider("", 0.1, 3.0, &mut speed); + ui.slider("##Speed", 0.1, 3.0, &mut speed); ui.same_line(); if ui.button("Reset") { speed = 1.0 @@ -254,7 +254,7 @@ impl LiveDebugger { let stages: Vec<&ImStr> = self.stages.iter().map(|e| e.as_ref()).collect(); ui.push_item_width(-1.0); - ui.list_box("", &mut self.selected_stage, &stages, 10); + ui.list_box("##SelectedStage", &mut self.selected_stage, &stages, 10); if ui.button("Load") { match GameScene::new(state, ctx, self.selected_stage as usize) { @@ -338,7 +338,7 @@ impl LiveDebugger { ))); ui.push_item_width(-1.0); - ui.list_box("", &mut self.selected_event, &events, 10); + ui.list_box("##SelectedEvent", &mut self.selected_event, &events, 10); if ui.button("Execute") { assert_eq!(self.event_ids.len(), self.events.len()); @@ -573,4 +573,4 @@ fn cond_flags(ui: &imgui::Ui, cond: &mut crate::common::Condition) { ui.checkbox_flags("Increased acceleration", &mut cond.0, 32); ui.checkbox_flags("Unknown (0x40)", &mut cond.0, 64); ui.checkbox_flags("Alive", &mut cond.0, 128); -} +} \ No newline at end of file