mirror of
https://git.h3cjp.net/H3cJP/yuzu.git
synced 2024-11-14 13:22:49 +00:00
yuzu/configuration/configure_input: Default destructor in the cpp file
The previous code could potentially be a compilation issue waiting to occur, given we forward declare the type for a std::unique_ptr. If the complete definition of the forward declared type isn't visible in a translation unit that the class is used in, then it would fail to compile. Defaulting the destructor in a cpp file ensures the std::unique_ptr's destructor is only invoked where its complete type is known.
This commit is contained in:
parent
7ce17b2cf6
commit
f3253d0f14
|
@ -88,6 +88,8 @@ ConfigureInput::ConfigureInput(QWidget* parent)
|
||||||
[this] { CallConfigureDialog<ConfigureTouchscreenAdvanced>(*this); });
|
[this] { CallConfigureDialog<ConfigureTouchscreenAdvanced>(*this); });
|
||||||
}
|
}
|
||||||
|
|
||||||
|
ConfigureInput::~ConfigureInput() = default;
|
||||||
|
|
||||||
void ConfigureInput::OnDockedModeChanged(bool last_state, bool new_state) {
|
void ConfigureInput::OnDockedModeChanged(bool last_state, bool new_state) {
|
||||||
if (ui->use_docked_mode->isChecked() && ui->handheld_connected->isChecked()) {
|
if (ui->use_docked_mode->isChecked() && ui->handheld_connected->isChecked()) {
|
||||||
ui->handheld_connected->setChecked(false);
|
ui->handheld_connected->setChecked(false);
|
||||||
|
|
|
@ -25,6 +25,7 @@ class ConfigureInput : public QWidget {
|
||||||
|
|
||||||
public:
|
public:
|
||||||
explicit ConfigureInput(QWidget* parent = nullptr);
|
explicit ConfigureInput(QWidget* parent = nullptr);
|
||||||
|
~ConfigureInput() override;
|
||||||
|
|
||||||
/// Save all button configurations to settings file
|
/// Save all button configurations to settings file
|
||||||
void applyConfiguration();
|
void applyConfiguration();
|
||||||
|
|
Loading…
Reference in a new issue