From cda31d3dc788d3411385763e92b943bbdd84d39a Mon Sep 17 00:00:00 2001 From: naskya Date: Wed, 8 May 2024 06:06:31 +0900 Subject: [PATCH] Revert "refactor (backend): port publishNotesStream to backend-rs" This reverts commit 5382dc5da857c768bfcf539d69d2a60fc5ab975d. It turns out this sends an inccorect time info to the stream since JavaScript's Date object doesn't have timezone info I'll revisit this in the future --- packages/backend-rs/index.d.ts | 1 - packages/backend-rs/index.js | 3 +-- packages/backend-rs/src/service/stream.rs | 3 +-- packages/backend-rs/src/service/stream/new_note.rs | 10 ---------- packages/backend/src/services/note/create.ts | 9 ++++++--- packages/backend/src/services/stream.ts | 9 ++++----- 6 files changed, 12 insertions(+), 23 deletions(-) delete mode 100644 packages/backend-rs/src/service/stream/new_note.rs diff --git a/packages/backend-rs/index.d.ts b/packages/backend-rs/index.d.ts index 436529ca67..b161473d9a 100644 --- a/packages/backend-rs/index.d.ts +++ b/packages/backend-rs/index.d.ts @@ -1292,7 +1292,6 @@ export interface AbuseUserReportLike { comment: string } export function publishToModerationStream(moderatorId: string, report: AbuseUserReportLike): void -export function publishToNotesStream(note: Note): void export function getTimestamp(id: string): number /** * The generated ID results in the form of `[8 chars timestamp] + [cuid2]`. diff --git a/packages/backend-rs/index.js b/packages/backend-rs/index.js index 96f14541d1..0d9938f9ed 100644 --- a/packages/backend-rs/index.js +++ b/packages/backend-rs/index.js @@ -310,7 +310,7 @@ if (!nativeBinding) { throw new Error(`Failed to load native binding`) } -const { SECOND, MINUTE, HOUR, DAY, USER_ONLINE_THRESHOLD, USER_ACTIVE_THRESHOLD, FILE_TYPE_BROWSERSAFE, loadEnv, loadConfig, stringToAcct, acctToString, addNoteToAntenna, isBlockedServer, isSilencedServer, isAllowedServer, checkWordMute, getFullApAccount, isSelfHost, isSameOrigin, extractHost, toPuny, isUnicodeEmoji, sqlLikeEscape, safeForSql, formatMilliseconds, getImageSizeFromUrl, getNoteSummary, isSafeUrl, latestVersion, toMastodonId, fromMastodonId, fetchMeta, metaToPugArgs, nyaify, hashPassword, verifyPassword, isOldPasswordAlgorithm, decodeReaction, countReactions, toDbReaction, removeOldAttestationChallenges, AntennaSrcEnum, DriveFileUsageHintEnum, MutedNoteReasonEnum, NoteVisibilityEnum, NotificationTypeEnum, PageVisibilityEnum, PollNotevisibilityEnum, RelayStatusEnum, UserEmojimodpermEnum, UserProfileFfvisibilityEnum, UserProfileMutingnotificationtypesEnum, initializeRustLogger, fetchNodeinfo, nodeinfo_2_1, nodeinfo_2_0, Protocol, Inbound, Outbound, watchNote, unwatchNote, publishToChannelStream, ChatEvent, publishToChatStream, ChatIndexEvent, publishToChatIndexStream, publishToBroadcastStream, publishToGroupChatStream, publishToModerationStream, publishToNotesStream, getTimestamp, genId, genIdAt, secureRndstr } = nativeBinding +const { SECOND, MINUTE, HOUR, DAY, USER_ONLINE_THRESHOLD, USER_ACTIVE_THRESHOLD, FILE_TYPE_BROWSERSAFE, loadEnv, loadConfig, stringToAcct, acctToString, addNoteToAntenna, isBlockedServer, isSilencedServer, isAllowedServer, checkWordMute, getFullApAccount, isSelfHost, isSameOrigin, extractHost, toPuny, isUnicodeEmoji, sqlLikeEscape, safeForSql, formatMilliseconds, getImageSizeFromUrl, getNoteSummary, isSafeUrl, latestVersion, toMastodonId, fromMastodonId, fetchMeta, metaToPugArgs, nyaify, hashPassword, verifyPassword, isOldPasswordAlgorithm, decodeReaction, countReactions, toDbReaction, removeOldAttestationChallenges, AntennaSrcEnum, DriveFileUsageHintEnum, MutedNoteReasonEnum, NoteVisibilityEnum, NotificationTypeEnum, PageVisibilityEnum, PollNotevisibilityEnum, RelayStatusEnum, UserEmojimodpermEnum, UserProfileFfvisibilityEnum, UserProfileMutingnotificationtypesEnum, initializeRustLogger, fetchNodeinfo, nodeinfo_2_1, nodeinfo_2_0, Protocol, Inbound, Outbound, watchNote, unwatchNote, publishToChannelStream, ChatEvent, publishToChatStream, ChatIndexEvent, publishToChatIndexStream, publishToBroadcastStream, publishToGroupChatStream, publishToModerationStream, getTimestamp, genId, genIdAt, secureRndstr } = nativeBinding module.exports.SECOND = SECOND module.exports.MINUTE = MINUTE @@ -381,7 +381,6 @@ module.exports.publishToChatIndexStream = publishToChatIndexStream module.exports.publishToBroadcastStream = publishToBroadcastStream module.exports.publishToGroupChatStream = publishToGroupChatStream module.exports.publishToModerationStream = publishToModerationStream -module.exports.publishToNotesStream = publishToNotesStream module.exports.getTimestamp = getTimestamp module.exports.genId = genId module.exports.genIdAt = genIdAt diff --git a/packages/backend-rs/src/service/stream.rs b/packages/backend-rs/src/service/stream.rs index bf957a6e9b..279d343f10 100644 --- a/packages/backend-rs/src/service/stream.rs +++ b/packages/backend-rs/src/service/stream.rs @@ -5,7 +5,6 @@ pub mod chat_index; pub mod custom_emoji; pub mod group_chat; pub mod moderation; -pub mod new_note; use crate::config::CONFIG; use crate::database::redis_conn; @@ -26,7 +25,7 @@ pub enum Stream { #[strum(to_string = "noteStream:{note_id}")] Note { note_id: String }, #[strum(serialize = "notesStream")] - NewNote, + Notes, #[strum(to_string = "userListStream:{list_id}")] UserList { list_id: String }, #[strum(to_string = "mainStream:{user_id}")] diff --git a/packages/backend-rs/src/service/stream/new_note.rs b/packages/backend-rs/src/service/stream/new_note.rs deleted file mode 100644 index 5386252ff7..0000000000 --- a/packages/backend-rs/src/service/stream/new_note.rs +++ /dev/null @@ -1,10 +0,0 @@ -use crate::model::entity::note; -use crate::service::stream::{publish_to_stream, Error, Stream}; - -// for napi export (https://github.com/napi-rs/napi-rs/issues/2060) -type Note = note::Model; - -#[crate::export(js_name = "publishToNotesStream")] -pub fn publish(note: &Note) -> Result<(), Error> { - publish_to_stream(&Stream::NewNote, None, Some(serde_json::to_string(note)?)) -} diff --git a/packages/backend/src/services/note/create.ts b/packages/backend/src/services/note/create.ts index 95670b06b5..2096f8b1a2 100644 --- a/packages/backend/src/services/note/create.ts +++ b/packages/backend/src/services/note/create.ts @@ -1,5 +1,9 @@ import * as mfm from "mfm-js"; -import { publishMainStream, publishNoteStream } from "@/services/stream.js"; +import { + publishMainStream, + publishNotesStream, + publishNoteStream, +} from "@/services/stream.js"; import DeliverManager from "@/remote/activitypub/deliver-manager.js"; import renderNote from "@/remote/activitypub/renderer/note.js"; import renderCreate from "@/remote/activitypub/renderer/create.js"; @@ -45,7 +49,6 @@ import { genId, genIdAt, isSilencedServer, - publishToNotesStream, } from "backend-rs"; import { countSameRenotes } from "@/misc/count-same-renotes.js"; import { deliverToRelays, getCachedRelays } from "../relay.js"; @@ -508,7 +511,7 @@ export default async ( 30, ); } - publishToNotesStream(toRustObject(noteToPublish)); + publishNotesStream(noteToPublish); } } finally { await lock.release(); diff --git a/packages/backend/src/services/stream.ts b/packages/backend/src/services/stream.ts index c60d5ce974..36914d4d41 100644 --- a/packages/backend/src/services/stream.ts +++ b/packages/backend/src/services/stream.ts @@ -193,10 +193,9 @@ class Publisher { // ); // }; - /* ported to backend-rs */ - // public publishNotesStream = (note: Note): void => { - // this.publish("notesStream", null, note); - // }; + public publishNotesStream = (note: Note): void => { + this.publish("notesStream", null, note); + }; /* ported to backend-rs */ // public publishAdminStream = ( @@ -222,7 +221,7 @@ export const publishUserEvent = publisher.publishUserEvent; export const publishMainStream = publisher.publishMainStream; export const publishDriveStream = publisher.publishDriveStream; export const publishNoteStream = publisher.publishNoteStream; -// export const publishNotesStream = publisher.publishNotesStream; +export const publishNotesStream = publisher.publishNotesStream; // export const publishChannelStream = publisher.publishChannelStream; export const publishUserListStream = publisher.publishUserListStream; // export const publishAntennaStream = publisher.publishAntennaStream;