From 7e40424b8985e720caa5b3c8fcc3f0a90053b6f5 Mon Sep 17 00:00:00 2001
From: naskya <m@naskya.net>
Date: Thu, 23 May 2024 20:49:46 +0900
Subject: [PATCH] meta: bump required Node.js version to v18.19.0

ref: https://github.com/sindresorhus/execa/releases/tag/v9.0.0
---
 dev/container/docker-compose.yml    | 2 +-
 dev/docs/local-installation.md      | 2 +-
 docs/install.md                     | 2 +-
 docs/notice-for-admins.md           | 6 ++++++
 packages/backend/src/boot/master.ts | 2 +-
 5 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/dev/container/docker-compose.yml b/dev/container/docker-compose.yml
index 6416b70025..8768a095f3 100644
--- a/dev/container/docker-compose.yml
+++ b/dev/container/docker-compose.yml
@@ -2,7 +2,7 @@ version: "3"
 
 services:
   web:
-    image: docker.io/node:18.17.0-bookworm
+    image: docker.io/node:18.19.0-bookworm
     container_name: firefish_web
     restart: unless-stopped
     depends_on:
diff --git a/dev/docs/local-installation.md b/dev/docs/local-installation.md
index 5d8a094f73..70f1d4c489 100644
--- a/dev/docs/local-installation.md
+++ b/dev/docs/local-installation.md
@@ -15,7 +15,7 @@ sudo apt install build-essential python3 curl wget git lsb-release
 
 ### Node.js
 
-Firefish requires Node.js v18.17.0 or later. While you can choose any versions between v18.17.0 and the latest version (v21.6.2 as of writing), we recommend that you install v18.x so as not to use new features inadvertently and introduce incompatibility issues.
+Firefish requires Node.js v18.19.0 or later. While you can choose any versions between v18.19.0 and the latest version (v22.2.0 as of writing), we recommend that you install v18.x so as not to use new features inadvertently and introduce incompatibility issues.
 
 Instructions can be found at [this repository](https://github.com/nodesource/distributions).
 
diff --git a/docs/install.md b/docs/install.md
index f13a32d8eb..80dffdaeb9 100644
--- a/docs/install.md
+++ b/docs/install.md
@@ -4,7 +4,7 @@ Firefish depends on the following software.
 
 ## Runtime dependencies
 
-- At least [NodeJS](https://nodejs.org/en/) v18.17.0 (v20/v21 recommended)
+- At least [NodeJS](https://nodejs.org/en/) v18.19.0 (v20/v21 recommended)
 - At least [PostgreSQL](https://www.postgresql.org/) v12 (v16 recommended) with [PGroonga](https://pgroonga.github.io/) extension
 - At least [Redis](https://redis.io/) v7
 - Web Proxy (one of the following)
diff --git a/docs/notice-for-admins.md b/docs/notice-for-admins.md
index e8e020c2d0..5471832c83 100644
--- a/docs/notice-for-admins.md
+++ b/docs/notice-for-admins.md
@@ -2,6 +2,12 @@
 
 You can skip intermediate versions when upgrading from an old version, but please read the notices and follow the instructions for each intermediate version before [upgrading](./upgrade.md).
 
+## Unreleased
+
+### For systemd/pm2 users
+
+Required Node.js version has been bumped from v18.17.0 to v18.19.0. Also, as written in the [v20240430 note](https://firefish.dev/firefish/firefish/-/blob/d3394b97f021dea323ec3ae36e39930680242482/docs/notice-for-admins.md#v20240430), it is highly recommended that you use an even newer version since v18.19.0 has known vulnerabilities.
+
 ## v20240523
 
 ### For all users
diff --git a/packages/backend/src/boot/master.ts b/packages/backend/src/boot/master.ts
index b331eb898d..e065492eae 100644
--- a/packages/backend/src/boot/master.ts
+++ b/packages/backend/src/boot/master.ts
@@ -79,7 +79,7 @@ function showNodejsVersion(): void {
 
 	nodejsLogger.info(`Version ${process.version} detected.`);
 
-	const minVersion = "v18.17.0";
+	const minVersion = "v18.19.0";
 	if (semver.lt(process.version, minVersion)) {
 		nodejsLogger.error(`At least Node.js ${minVersion} required!`);
 		process.exit(1);