lux/citra
1
0
Fork 0
mirror of https://git.h3cjp.net/H3cJP/citra.git synced 2024-11-25 17:52:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

kernel/wait_object: Devirtualize functions related to manipulating the thread list directly

Browse source 
No inheritors of the WaitObject class actually make use of their own
implementations of these functions, so they can be made non-virtual.

It's also kind of sketchy to allow overriding how the threads get added
to the list anyways, given the kernel itself on the actual hardware
doesn't seem to customize based off this.
This commit is contained in:
Lioncash 2019-01-30 12:41:17 -05:00
parent 4596ef5274
commit a3cdd773c3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/core/hle/kernel/wait_object.h
View file

@ -33,19 +33,19 @@ public:
* Add a thread to wait on this object * Add a thread to wait on this object
* @param thread Pointer to thread to add * @param thread Pointer to thread to add
*/ */
virtual void AddWaitingThread(SharedPtr<Thread> thread); void AddWaitingThread(SharedPtr<Thread> thread);
/** /**
* Removes a thread from waiting on this object (e.g. if it was resumed already) * Removes a thread from waiting on this object (e.g. if it was resumed already)
* @param thread Pointer to thread to remove * @param thread Pointer to thread to remove
*/ */
virtual void RemoveWaitingThread(Thread* thread); void RemoveWaitingThread(Thread* thread);
/** /**
* Wake up all threads waiting on this object that can be awoken, in priority order, * Wake up all threads waiting on this object that can be awoken, in priority order,
* and set the synchronization result and output of the thread. * and set the synchronization result and output of the thread.
*/ */
virtual void WakeupAllWaitingThreads(); void WakeupAllWaitingThreads();
/** /**
* Wakes up a single thread waiting on this object. * Wakes up a single thread waiting on this object.