From 587b68ed17aa5dd46dc4583d3ee90d6ec3ba5894 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 5 Jun 2019 15:43:55 -0400 Subject: [PATCH] yuzu/CMakeLists: Disable implicit type narrowing in connect() calls Prevents hard-to-diagnose bugs from potentially occurring and requires any type narrowing to be explicitly performed by our code. --- src/citra_qt/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/citra_qt/CMakeLists.txt b/src/citra_qt/CMakeLists.txt index 502531fca8..8b543c731e 100644 --- a/src/citra_qt/CMakeLists.txt +++ b/src/citra_qt/CMakeLists.txt @@ -228,6 +228,9 @@ target_compile_definitions(citra-qt PRIVATE # Use QStringBuilder for string concatenation to reduce # the overall number of temporary strings created. -DQT_USE_QSTRINGBUILDER + + # Disable implicit type narrowing in signal/slot connect() calls. + -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT ) if (CITRA_ENABLE_COMPATIBILITY_REPORTING)