From 52f12e303ac93437d6a8a4e8c04ee5311dac71d3 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 11 Sep 2018 22:28:28 -0400 Subject: [PATCH] game_list: Use QJsonValueRef() within LoadCompatibilityList() This way, we aren't constructing unnecessary QJsonValue instances. --- src/citra_qt/game_list.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/citra_qt/game_list.cpp b/src/citra_qt/game_list.cpp index 390d0c7e5b..f12cc41d34 100644 --- a/src/citra_qt/game_list.cpp +++ b/src/citra_qt/game_list.cpp @@ -545,7 +545,7 @@ void GameList::LoadCompatibilityList() { QJsonDocument json = QJsonDocument::fromJson(string_content.toUtf8()); QJsonArray arr = json.array(); - for (const QJsonValue& value : arr) { + for (const QJsonValueRef& value : arr) { QJsonObject game = value.toObject(); if (game.contains("compatibility") && game["compatibility"].isDouble()) { @@ -553,7 +553,7 @@ void GameList::LoadCompatibilityList() { QString directory = game["directory"].toString(); QJsonArray ids = game["releases"].toArray(); - for (const QJsonValue& value : ids) { + for (const QJsonValueRef& value : ids) { QJsonObject object = value.toObject(); QString id = object["id"].toString(); compatibility_list.emplace(