diff --git a/src/audio_core/hle/decoder.cpp b/src/audio_core/hle/decoder.cpp index 06ee0bca43..a4d4be181e 100644 --- a/src/audio_core/hle/decoder.cpp +++ b/src/audio_core/hle/decoder.cpp @@ -55,7 +55,7 @@ std::optional NullDecoder::ProcessRequest(const BinaryRequest& r return response; default: LOG_ERROR(Audio_DSP, "Got unknown binary request: {}", static_cast(request.cmd)); - return {}; + return std::nullopt; } }; } // namespace AudioCore::HLE diff --git a/src/audio_core/hle/wmf_decoder.cpp b/src/audio_core/hle/wmf_decoder.cpp index 27899282b7..d1aa452b74 100644 --- a/src/audio_core/hle/wmf_decoder.cpp +++ b/src/audio_core/hle/wmf_decoder.cpp @@ -104,7 +104,7 @@ WMFDecoder::Impl::~Impl() { std::optional WMFDecoder::Impl::ProcessRequest(const BinaryRequest& request) { if (request.codec != DecoderCodec::AAC) { LOG_ERROR(Audio_DSP, "Got unknown codec {}", static_cast(request.codec)); - return {}; + return std::nullopt; } switch (request.cmd) { @@ -123,7 +123,7 @@ std::optional WMFDecoder::Impl::ProcessRequest(const BinaryReque } default: LOG_ERROR(Audio_DSP, "Got unknown binary request: {}", static_cast(request.cmd)); - return {}; + return std::nullopt; } } @@ -205,7 +205,7 @@ std::optional WMFDecoder::Impl::Decode(const BinaryRequest& requ if (request.src_addr < Memory::FCRAM_PADDR || request.src_addr + request.size > Memory::FCRAM_PADDR + Memory::FCRAM_SIZE) { LOG_ERROR(Audio_DSP, "Got out of bounds src_addr {:08x}", request.src_addr); - return {}; + return std::nullopt; } u8* data = memory.GetFCRAMPointer(request.src_addr - Memory::FCRAM_PADDR); @@ -269,7 +269,7 @@ std::optional WMFDecoder::Impl::Decode(const BinaryRequest& requ request.dst_addr_ch0 + out_streams[0].size() > Memory::FCRAM_PADDR + Memory::FCRAM_SIZE) { LOG_ERROR(Audio_DSP, "Got out of bounds dst_addr_ch0 {:08x}", request.dst_addr_ch0); - return {}; + return std::nullopt; } std::memcpy(memory.GetFCRAMPointer(request.dst_addr_ch0 - Memory::FCRAM_PADDR), out_streams[0].data(), out_streams[0].size()); @@ -280,7 +280,7 @@ std::optional WMFDecoder::Impl::Decode(const BinaryRequest& requ request.dst_addr_ch1 + out_streams[1].size() > Memory::FCRAM_PADDR + Memory::FCRAM_SIZE) { LOG_ERROR(Audio_DSP, "Got out of bounds dst_addr_ch1 {:08x}", request.dst_addr_ch1); - return {}; + return std::nullopt; } std::memcpy(memory.GetFCRAMPointer(request.dst_addr_ch1 - Memory::FCRAM_PADDR), out_streams[1].data(), out_streams[1].size()); diff --git a/src/core/hle/kernel/memory.cpp b/src/core/hle/kernel/memory.cpp index a4e77e0b29..a755507b11 100644 --- a/src/core/hle/kernel/memory.cpp +++ b/src/core/hle/kernel/memory.cpp @@ -234,7 +234,7 @@ std::optional MemoryRegionInfo::LinearAllocate(u32 size) { } // No sufficient block found - return {}; + return std::nullopt; } void MemoryRegionInfo::Free(u32 offset, u32 size) { diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index b36228628e..e52aa0869f 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp @@ -928,7 +928,7 @@ std::optional DecompileProgram(const Pica::Shader::ProgramCode& p return {ProgramResult{generator.MoveShaderCode()}}; } catch (const DecompileFail& exception) { LOG_INFO(HW_GPU, "Shader decompilation failed: {}", exception.what()); - return {}; + return std::nullopt; } } diff --git a/src/video_core/renderer_opengl/gl_shader_gen.cpp b/src/video_core/renderer_opengl/gl_shader_gen.cpp index 77429b887c..3172d610bb 100644 --- a/src/video_core/renderer_opengl/gl_shader_gen.cpp +++ b/src/video_core/renderer_opengl/gl_shader_gen.cpp @@ -1651,7 +1651,7 @@ std::optional GenerateVertexShader( get_output_reg, config.state.sanitize_mul); if (!program_source_opt) - return {}; + return std::nullopt; std::string& program_source = program_source_opt->code;