mirror of
https://github.com/lunaisnotaboy/mastodon.git
synced 2024-09-12 05:07:06 +00:00
In #2110, a new attachment type "unknown" was introduced for attachments that were rejected due to a domain being blocked using reject_media. However, the "type" field was never set to "unknown" because a default value of "0" (image) is set for that column, causing the `type.blank?` expression to always equal false. This version uses type_changed? instead, causing the type to be set to "unknown" unless a type has been explicitly set. This introduces a small change in behaviour causing the type to be set to unknown before paperclip calls `before_post_process`. Presumably this behaviour is more appropriate than the current one because the attachment type has not been determined by that point. Included are new tests for `ProcessFeedService` and `UpdateRemoteProfileService` which now check that remote media is downloaded for non-blocked domains and is rejected for others. |
||
---|---|---|
.. | ||
account_search_service_spec.rb | ||
authorize_follow_service_spec.rb | ||
block_domain_service_spec.rb | ||
block_service_spec.rb | ||
fan_out_on_write_service_spec.rb | ||
favourite_service_spec.rb | ||
fetch_atom_service_spec.rb | ||
fetch_link_card_service_spec.rb | ||
fetch_remote_account_service_spec.rb | ||
fetch_remote_status_service_spec.rb | ||
follow_remote_account_service_spec.rb | ||
follow_service_spec.rb | ||
mute_service_spec.rb | ||
post_status_service_spec.rb | ||
precompute_feed_service_spec.rb | ||
process_feed_service_spec.rb | ||
process_interaction_service_spec.rb | ||
process_mentions_service_spec.rb | ||
reblog_service_spec.rb | ||
reject_follow_service_spec.rb | ||
send_interaction_service_spec.rb | ||
unblock_service_spec.rb | ||
unfollow_service_spec.rb | ||
unmute_service_spec.rb | ||
update_remote_profile_service_spec.rb |