Claire 0a120d86d2 Fix error-prone SQL queries (#15828) ... * Fix error-prone SQL queries in Account search While this code seems to not present an actual vulnerability, one could easily be introduced by mistake due to how the query is built. This PR parameterises the `to_tsquery` input to make the query more robust. * Harden code for Status#tagged_with_all and Status#tagged_with_none Those two scopes aren't used in a way that could be vulnerable to an SQL injection, but keeping them unchanged might be a hazard. * Remove unneeded spaces surrounding tsquery term * Please CodeClimate * Move advanced_search_for SQL template to its own function This avoids one level of indentation while making clearer that the SQL template isn't build from all the dynamic parameters of advanced_search_for. * Add tests covering tagged_with, tagged_with_all and tagged_with_none * Rewrite tagged_with_none to avoid multiple joins and make it more robust * Remove obsolete brakeman warnings * Revert "Remove unneeded spaces surrounding tsquery term" The two queries are not strictly equivalent. This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.		2022-01-23 18:10:10 +01:00
..
account_suggestions	Change auto-following admin-selected accounts, show in recommendations (#16078)	2021-04-24 17:01:43 +02:00
admin	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
concerns	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
form	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
trends	Change trending hashtags threshold back from 15 to 5 (#17122)	2021-12-13 05:32:29 +01:00
web	Add policy param to POST /api/v1/push/subscriptions (#16040)	2021-04-15 05:00:25 +02:00
account.rb	Fix error-prone SQL queries (#15828)	2022-01-23 18:10:10 +01:00
account_alias.rb
account_conversation.rb
account_deletion_request.rb
account_domain_block.rb
account_filter.rb	Remove IP tracking columns from users table (#16409)	2022-01-16 13:23:50 +01:00
account_migration.rb	Fix race conditions on account migration creation (#15597)	2021-02-02 14:49:57 +01:00
account_moderation_note.rb
account_note.rb	Fix AccountNote not having a maximum length (#16942)	2021-11-06 00:12:25 +01:00
account_pin.rb
account_stat.rb	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915)	2021-11-18 22:02:08 +01:00
account_statuses_cleanup_policy.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
account_suggestions.rb	Change auto-following admin-selected accounts, show in recommendations (#16078)	2021-04-24 17:01:43 +02:00
account_summary.rb	Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)	2021-05-09 10:39:29 +02:00
account_warning.rb	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
account_warning_preset.rb
admin.rb
announcement.rb
announcement_filter.rb
announcement_mute.rb
announcement_reaction.rb
application_record.rb
backup.rb
block.rb
bookmark.rb	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915)	2021-11-18 22:02:08 +01:00
canonical_email_block.rb	Add ability for admins to delete canonical email blocks (#16644)	2021-12-17 23:02:14 +01:00
context.rb
conversation.rb
conversation_mute.rb
custom_emoji.rb	Switch from unmaintained paperclip to kt-paperclip (#16724)	2021-09-29 23:52:36 +02:00
custom_emoji_category.rb
custom_emoji_filter.rb
custom_filter.rb	Optimize map { ... }.compact calls (#15513)	2021-01-10 00:32:01 +01:00
device.rb
domain_allow.rb	Fix performance on instances list in admin UI (#15282)	2020-12-14 09:06:34 +01:00
domain_block.rb	Add option to obfuscate domain name in public list of domain blocks (#15355)	2020-12-18 08:30:41 +01:00
email_domain_block.rb
encrypted_message.rb
export.rb	Add import/export feature for bookmarks (#14956)	2020-11-19 17:48:13 +01:00
favourite.rb	Bump chewy from 5.2.0 to 7.2.3 (supports Elasticsearch 7.x) (#16915)	2021-11-18 22:02:08 +01:00
featured_tag.rb
feed.rb
follow.rb	Fix being able to import more than allowed number of follows (#15384)	2020-12-26 23:52:46 +01:00
follow_recommendation.rb	Fix FollowRecommendationsScheduler failing because of unpopulated views (#16189)	2021-05-09 10:39:29 +02:00
follow_recommendation_filter.rb	Add cold-start follow recommendations (#15945)	2021-04-12 12:37:14 +02:00
follow_recommendation_suppression.rb	Add cold-start follow recommendations (#15945)	2021-04-12 12:37:14 +02:00
follow_request.rb	Fix edge case where accepted follow cannot be processed because of follow limit (#16098)	2021-04-23 22:51:21 +02:00
home_feed.rb	Fix rubocop config and warnings (#15503)	2021-01-07 09:40:55 +01:00
identity.rb
import.rb	Fix follow limit preventing re-following of a moved account (#14207)	2020-12-18 09:18:31 +01:00
instance.rb	Add management of delivery availability in Federation settings (#15771)	2021-05-05 23:39:02 +02:00
instance_filter.rb	Add management of delivery availability in Federation settings (#15771)	2021-05-05 23:39:02 +02:00
invite.rb
invite_filter.rb
ip_block.rb
list.rb	Improve account deletion performances further (#15407)	2020-12-22 23:57:46 +01:00
list_account.rb
list_feed.rb	Fix rubocop config and warnings (#15503)	2021-01-07 09:40:55 +01:00
login_activity.rb	Add authentication history (#16408)	2021-06-21 17:07:30 +02:00
marker.rb
media_attachment.rb	Fix error when rendering public pages with media attachments (#16763)	2021-10-13 15:27:19 +02:00
mention.rb
message_franking.rb
mute.rb
notification.rb	Prepare Mastodon for Rails 6 (#15911)	2021-03-17 10:09:55 +01:00
one_time_key.rb
poll.rb	Add support for editing for published statuses (#16697)	2022-01-19 22:37:27 +01:00
poll_vote.rb
preview_card.rb	Fix error on trending hashtags/links pages in admin UI due to missing constant (#17044)	2021-11-26 01:12:39 +01:00
preview_card_filter.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
preview_card_provider.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
preview_card_provider_filter.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
public_feed.rb	Fix rubocop config and warnings (#15503)	2021-01-07 09:40:55 +01:00
relationship_filter.rb
relay.rb
remote_follow.rb
report.rb	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
report_filter.rb	Add notifications for statuses deleted by moderators (#17204)	2022-01-17 09:41:33 +01:00
report_note.rb
rule.rb	Add server rules (#15769)	2021-02-21 19:50:12 +01:00
scheduled_status.rb
search.rb
session_activation.rb	Add Ruby 3.0 support (#16046)	2021-05-06 14:22:54 +02:00
setting.rb	Use Rails' index_by where it makes sense (#15542)	2021-01-12 09:27:38 +01:00
site_upload.rb
status.rb	Fix error-prone SQL queries (#15828)	2022-01-23 18:10:10 +01:00
status_edit.rb	Add support for editing for published statuses (#16697)	2022-01-19 22:37:27 +01:00
status_pin.rb	Add feature to automatically delete old toots (#16529)	2021-08-09 23:11:50 +02:00
status_stat.rb
system_key.rb
tag.rb	Fix error on trending hashtags/links pages in admin UI due to missing constant (#17044)	2021-11-26 01:12:39 +01:00
tag_feed.rb	Fix rubocop config and warnings (#15503)	2021-01-07 09:40:55 +01:00
tag_filter.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
tombstone.rb
trends.rb	Add trending links (#16917)	2021-11-25 13:07:38 +01:00
unavailable_domain.rb	Fix performance on instances list in admin UI (#15282)	2020-12-14 09:06:34 +01:00
user.rb	Remove leftover database columns from Devise::Models::Rememberable (#17191)	2022-01-23 15:46:30 +01:00
user_invite_request.rb
user_ip.rb	Remove IP tracking columns from users table (#16409)	2022-01-16 13:23:50 +01:00
web.rb
webauthn_credential.rb