mirror of
https://github.com/lunaisnotaboy/mastodon.git
synced 2024-12-22 05:08:03 +00:00
d4c94fa004
Checking reblog vs original status was happening in multiple places across the app. For views, this logic was encapsulated in a helper method named `proper_status` but in the other layers of the app, the logic was duplicated. Because the logic is used at all layers of the app, we extracted it into a `Status#proper` method on the model and changed all uses of the logic to use this method. There is now a single source of truth for this condition. We added test coverage to untested methods that got refactored. |
||
|---|---|---|
| .. | ||
| web | ||
| account_spec.rb | ||
| block_spec.rb | ||
| domain_block_spec.rb | ||
| favourite_spec.rb | ||
| feed_spec.rb | ||
| follow_request_spec.rb | ||
| follow_spec.rb | ||
| import_spec.rb | ||
| media_attachment_spec.rb | ||
| mention_spec.rb | ||
| mute_spec.rb | ||
| notification_spec.rb | ||
| preview_card_spec.rb | ||
| report_spec.rb | ||
| status_spec.rb | ||
| stream_entry_spec.rb | ||
| subscription_spec.rb | ||
| tag_spec.rb | ||
| user_spec.rb | ||