mirror of
https://github.com/lunaisnotaboy/mastodon.git
synced 2024-08-20 15:25:14 +00:00
* Add code for creating/managing apps to settings section * Add specs for app changes * Fix controller spec * Fix view file I pasted over by mistake * Add locale strings. Add 'my apps' to nav * Add Client ID/Secret to App page. Add some visual separation * Fix rubocop warnings * Fix embarrassing typo I lost an `end` statement while fixing a merge conflict. * Add code for creating/managing apps to settings section - Add specs for app changes - Add locale strings. Add 'my apps' to nav - Add Client ID/Secret to App page. Add some visual separation - Fix some bugs/warnings * Update to match code standards * Trigger notification * Add warning about not sharing API secrets * Tweak spec a bit * Cleanup fixture creation by using let! * Remove unused key * Add foreign key for application<->user
167 lines
3.8 KiB
Ruby
167 lines
3.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Settings::ApplicationsController do
|
|
render_views
|
|
|
|
let!(:user) { Fabricate(:user) }
|
|
let!(:app) { Fabricate(:application, owner: user) }
|
|
|
|
before do
|
|
sign_in user, scope: :user
|
|
end
|
|
|
|
describe 'GET #index' do
|
|
let!(:other_app) { Fabricate(:application) }
|
|
|
|
it 'shows apps' do
|
|
get :index
|
|
expect(response).to have_http_status(:success)
|
|
expect(assigns(:applications)).to include(app)
|
|
expect(assigns(:applications)).to_not include(other_app)
|
|
end
|
|
end
|
|
|
|
|
|
describe 'GET #show' do
|
|
it 'returns http success' do
|
|
get :show, params: { id: app.id }
|
|
expect(response).to have_http_status(:success)
|
|
expect(assigns[:application]).to eql(app)
|
|
end
|
|
|
|
it 'returns 404 if you dont own app' do
|
|
app.update!(owner: nil)
|
|
|
|
get :show, params: { id: app.id }
|
|
expect(response.status).to eq 404
|
|
end
|
|
end
|
|
|
|
describe 'GET #new' do
|
|
it 'works' do
|
|
get :new
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
context 'success' do
|
|
def call_create
|
|
post :create, params: {
|
|
doorkeeper_application: {
|
|
name: 'My New App',
|
|
redirect_uri: 'urn:ietf:wg:oauth:2.0:oob',
|
|
website: 'http://google.com',
|
|
scopes: 'read write follow'
|
|
}
|
|
}
|
|
response
|
|
end
|
|
|
|
it 'creates an entry in the database' do
|
|
expect { call_create }.to change(Doorkeeper::Application, :count)
|
|
end
|
|
|
|
it 'redirects back to applications page' do
|
|
expect(call_create).to redirect_to(settings_applications_path)
|
|
end
|
|
end
|
|
|
|
context 'failure' do
|
|
before do
|
|
post :create, params: {
|
|
doorkeeper_application: {
|
|
name: '',
|
|
redirect_uri: '',
|
|
website: '',
|
|
scopes: ''
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'renders form again' do
|
|
expect(response).to render_template(:new)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PATCH #update' do
|
|
context 'success' do
|
|
let(:opts) {
|
|
{
|
|
website: 'https://foo.bar/'
|
|
}
|
|
}
|
|
|
|
def call_update
|
|
patch :update, params: {
|
|
id: app.id,
|
|
doorkeeper_application: opts
|
|
}
|
|
response
|
|
end
|
|
|
|
it 'updates existing application' do
|
|
call_update
|
|
expect(app.reload.website).to eql(opts[:website])
|
|
end
|
|
|
|
it 'redirects back to applications page' do
|
|
expect(call_update).to redirect_to(settings_applications_path)
|
|
end
|
|
end
|
|
|
|
context 'failure' do
|
|
before do
|
|
patch :update, params: {
|
|
id: app.id,
|
|
doorkeeper_application: {
|
|
name: '',
|
|
redirect_uri: '',
|
|
website: '',
|
|
scopes: ''
|
|
}
|
|
}
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'renders form again' do
|
|
expect(response).to render_template(:show)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'destroy' do
|
|
before do
|
|
post :destroy, params: { id: app.id }
|
|
end
|
|
|
|
it 'redirects back to applications page' do
|
|
expect(response).to redirect_to(settings_applications_path)
|
|
end
|
|
|
|
it 'removes the app' do
|
|
expect(Doorkeeper::Application.find_by(id: app.id)).to be_nil
|
|
end
|
|
end
|
|
|
|
describe 'regenerate' do
|
|
let(:token) { user.token_for_app(app) }
|
|
before do
|
|
expect(token).to_not be_nil
|
|
put :regenerate, params: { application_id: app.id }
|
|
end
|
|
|
|
it 'should create new token' do
|
|
expect(user.token_for_app(app)).to_not eql(token)
|
|
end
|
|
end
|
|
end
|