luna/mastodon
0
0
Fork 0
mirror of https://github.com/lunaisnotaboy/mastodon.git synced 2024-11-23 15:24:53 +00:00
Code Issues Projects Releases Wiki Activity
mastodon/spec
History
Eugen Rochko 21ad21cb50
Improve signature verification safeguards (#8959) 
* Downcase signed_headers string before building the signed string

The HTTP Signatures draft does not mandate the “headers” field to be downcased,
but mandates the header field names to be downcased in the signed string, which
means that prior to this patch, Mastodon could fail to process signatures from
some compliant clients. It also means that it would not actually check the
Digest of non-compliant clients that wouldn't use a lowercased Digest field
name.

Thankfully, I don't know of any such client.

* Revert "Remove dead code (#8919)"

This reverts commit a00ce8c92c.

* Restore time window checking, change it to 12 hours

By checking the Date header, we can prevent replaying old vulnerable
signatures. The focus is to prevent replaying old vulnerable requests
from software that has been fixed in the meantime, so a somewhat long
window should be fine and accounts for timezone misconfiguration.

* Escape users' URLs when formatting them

Fixes possible HTML injection

* Escape all string interpolations in Formatter class

Slightly improve performance by reducing class allocations
from repeated Formatter#encode calls

* Fix code style issues
2018-10-12 00:15:55 +02:00
..
controllers Improve signature verification safeguards (#8959) 2018-10-12 00:15:55 +02:00
fabricators rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
features rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
fixtures Slightly reduce RAM usage (#7301) 2018-05-02 18:58:48 +02:00
helpers Revert Font Awesome 5 upgrade (#8810) 2018-09-28 02:11:14 +02:00
lib rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
mailers
models rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
policies
presenters
requests Use raw status code on have_http_status (#7214) 2018-04-21 21:35:07 +02:00
routing
services rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
support
validators Add a spec for UniqueUsernameValidator (#6927) 2018-03-27 05:22:58 +02:00
views Replace SVG asset with Custom mascot (#8766) 2018-10-08 00:20:45 +02:00
workers
rails_helper.rb rubocop issues - Cleaning up (#8912) 2018-10-08 04:50:11 +02:00
spec_helper.rb Disable simplecov on CircleCI (#7416) 2018-05-09 16:59:58 +02:00