mirror of
https://github.com/lunaisnotaboy/mastodon.git
synced 2024-12-23 05:37:47 +00:00
27965ce5ed
* Add trending statuses * Fix dangling items with stale scores in localized sets * Various fixes and improvements - Change approve_all/reject_all to approve_accounts/reject_accounts - Change Trends::Query methods to not mutate the original query - Change Trends::Query#skip to offset - Change follow recommendations to be refreshed in a transaction * Add tests for trending statuses filtering behaviour * Fix not applying filtering scope in controller
68 lines
2.1 KiB
Ruby
68 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Scheduler::FollowRecommendationsScheduler
|
|
include Sidekiq::Worker
|
|
include Redisable
|
|
|
|
sidekiq_options retry: 0
|
|
|
|
# The maximum number of accounts that can be requested in one page from the
|
|
# API is 80, and the suggestions API does not allow pagination. This number
|
|
# leaves some room for accounts being filtered during live access
|
|
SET_SIZE = 100
|
|
|
|
def perform
|
|
# Maintaining a materialized view speeds-up subsequent queries significantly
|
|
AccountSummary.refresh
|
|
FollowRecommendation.refresh
|
|
|
|
fallback_recommendations = FollowRecommendation.order(rank: :desc).limit(SET_SIZE)
|
|
|
|
Trends.available_locales.each do |locale|
|
|
recommendations = begin
|
|
if AccountSummary.safe.filtered.localized(locale).exists? # We can skip the work if no accounts with that language exist
|
|
FollowRecommendation.localized(locale).order(rank: :desc).limit(SET_SIZE).map { |recommendation| [recommendation.account_id, recommendation.rank] }
|
|
else
|
|
[]
|
|
end
|
|
end
|
|
|
|
# Use language-agnostic results if there are not enough language-specific ones
|
|
missing = SET_SIZE - recommendations.size
|
|
|
|
if missing.positive? && fallback_recommendations.size.positive?
|
|
max_fallback_rank = fallback_recommendations.first.rank || 0
|
|
|
|
# Language-specific results should be above language-agnostic ones,
|
|
# otherwise language-agnostic ones will always overshadow them
|
|
recommendations.map! { |(account_id, rank)| [account_id, rank + max_fallback_rank] }
|
|
|
|
added = 0
|
|
|
|
fallback_recommendations.each do |recommendation|
|
|
next if recommendations.any? { |(account_id, _)| account_id == recommendation.account_id }
|
|
|
|
recommendations << [recommendation.account_id, recommendation.rank]
|
|
added += 1
|
|
|
|
break if added >= missing
|
|
end
|
|
end
|
|
|
|
redis.multi do |multi|
|
|
multi.del(key(locale))
|
|
|
|
recommendations.each do |(account_id, rank)|
|
|
multi.zadd(key(locale), rank, account_id)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def key(locale)
|
|
"follow_recommendations:#{locale}"
|
|
end
|
|
end
|