mirror of
https://github.com/lunaisnotaboy/mastodon.git
synced 2024-12-23 13:48:40 +00:00
051efed5ed
* Bypass MX validation for explicitly allowed domains This spares some lookups and prevent issues in some edge cases with local domains. * Add tests * Fix test
132 lines
7 KiB
Ruby
132 lines
7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe EmailMxValidator do
|
|
describe '#validate' do
|
|
let(:user) { double(email: 'foo@example.com', errors: double(add: nil)) }
|
|
|
|
it 'does not add errors if there are no DNS records for an e-mail domain that is explicitly allowed' do
|
|
old_whitelist = Rails.configuration.x.email_domains_whitelist
|
|
Rails.configuration.x.email_domains_whitelist = 'example.com'
|
|
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to_not have_received(:add)
|
|
|
|
Rails.configuration.x.email_domains_whitelist = old_whitelist
|
|
end
|
|
|
|
it 'adds an error if there are no DNS records for the e-mail domain' do
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if a MX record exists but does not lead to an IP' do
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([double(exchange: 'mail.example.com')])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if the A record is blacklisted' do
|
|
EmailDomainBlock.create!(domain: '1.2.3.4')
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([double(address: '1.2.3.4')])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if the AAAA record is blacklisted' do
|
|
EmailDomainBlock.create!(domain: 'fd00::1')
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([double(address: 'fd00::1')])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if the MX record is blacklisted' do
|
|
EmailDomainBlock.create!(domain: '2.3.4.5')
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([double(exchange: 'mail.example.com')])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::A).and_return([double(address: '2.3.4.5')])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if the MX IPv6 record is blacklisted' do
|
|
EmailDomainBlock.create!(domain: 'fd00::2')
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([double(exchange: 'mail.example.com')])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::AAAA).and_return([double(address: 'fd00::2')])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error if the MX hostname is blacklisted' do
|
|
EmailDomainBlock.create!(domain: 'mail.example.com')
|
|
resolver = double
|
|
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::MX).and_return([double(exchange: 'mail.example.com')])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::A).and_return([])
|
|
allow(resolver).to receive(:getresources).with('example.com', Resolv::DNS::Resource::IN::AAAA).and_return([])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::A).and_return([double(address: '2.3.4.5')])
|
|
allow(resolver).to receive(:getresources).with('mail.example.com', Resolv::DNS::Resource::IN::AAAA).and_return([double(address: 'fd00::2')])
|
|
allow(resolver).to receive(:timeouts=).and_return(nil)
|
|
allow(Resolv::DNS).to receive(:open).and_yield(resolver)
|
|
|
|
subject.validate(user)
|
|
expect(user.errors).to have_received(:add)
|
|
end
|
|
end
|
|
end
|