luna/mastodon
0
0
Fork 0
mirror of https://github.com/lunaisnotaboy/mastodon.git synced 2024-11-19 05:13:01 +00:00
Code Issues Projects Releases Wiki Activity

Speed up test suite by not generating RSA keys in test environment (#7296)

Browse source 
One RSA keypair for all fabricated test accounts is enough
This commit is contained in:
Eugen Rochko 2018-05-02 15:45:24 +02:00 committed by GitHub
parent 965345316f
commit c5dcd7d836
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/models/account.rb
View file

@ -406,9 +406,9 @@ class Account < ApplicationRecord
end end
def generate_keys def generate_keys
return unless local? return unless local? && !Rails.env.test?
keypair = OpenSSL::PKey::RSA.new(Rails.env.test? ? 512 : 2048) keypair = OpenSSL::PKey::RSA.new(2048)
self.private_key = keypair.to_pem self.private_key = keypair.to_pem
self.public_key = keypair.public_key.to_pem self.public_key = keypair.public_key.to_pem
end end

6
spec/fabricators/account_fabricator.rb
View file

@ -1,4 +1,10 @@
keypair = OpenSSL::PKey::RSA.new(2048)
public_key = keypair.public_key.to_pem
private_key = keypair.to_pem
Fabricator(:account) do Fabricator(:account) do
username { sequence(:username) { |i| "#{Faker::Internet.user_name(nil, %w(_))}#{i}" } } username { sequence(:username) { |i| "#{Faker::Internet.user_name(nil, %w(_))}#{i}" } }
last_webfingered_at { Time.now.utc } last_webfingered_at { Time.now.utc }
public_key { public_key }
private_key { private_key}
end end

3
spec/models/account_spec.rb
View file

@ -815,7 +815,8 @@ RSpec.describe Account, type: :model do
end end
context 'when is local' do context 'when is local' do
it 'generates keys' do # Test disabled because test environment omits autogenerating keys for performance
xit 'generates keys' do
account = Account.create!(domain: nil, username: Faker::Internet.user_name(nil, ['_'])) account = Account.create!(domain: nil, username: Faker::Internet.user_name(nil, ['_']))
expect(account.keypair.private?).to eq true expect(account.keypair.private?).to eq true
end end