From a823509b99eb428b1f68ed89594b88f48546253a Mon Sep 17 00:00:00 2001
From: Matt Jankowski <mjankowski@thoughtbot.com>
Date: Fri, 28 Apr 2017 11:54:03 -0400
Subject: [PATCH] Fix broken view spec for about/links (#2591)

---
 spec/views/about/_links.html.haml_spec.rb | 47 ++++++++++++-----------
 1 file changed, 25 insertions(+), 22 deletions(-)

diff --git a/spec/views/about/_links.html.haml_spec.rb b/spec/views/about/_links.html.haml_spec.rb
index a5d2c8924..2d7f7467a 100644
--- a/spec/views/about/_links.html.haml_spec.rb
+++ b/spec/views/about/_links.html.haml_spec.rb
@@ -3,33 +3,36 @@
 require 'rails_helper'
 
 describe 'about/_links.html.haml' do
-  it 'does not show sign in link when signed in' do
-    instance_presenter = double(:instance_presenter, open_registrations: true)
-    assign(:instance_presenter, instance_presenter)
-    allow(view).to receive(:user_signed_in?).and_return(true)
-    render 'about/links', instance: InstancePresenter.new
+  context 'when signed in' do
+    before do
+      allow(view).to receive(:user_signed_in?).and_return(true)
+    end
 
-    expect(rendered).to have_content(I18n.t('about.get_started'))
-    expect(rendered).not_to have_content(I18n.t('auth.login'))
+    it 'does not show sign in link' do
+      render 'about/links', instance: InstancePresenter.new
+
+      expect(rendered).to have_content(I18n.t('about.get_started'))
+      expect(rendered).not_to have_content(I18n.t('auth.login'))
+    end
   end
 
-  it 'shows sign in link when signed out' do
-    instance_presenter = double(:instance_presenter, open_registrations: true)
-    assign(:instance_presenter, instance_presenter)
-    allow(view).to receive(:user_signed_in?).and_return(false)
-    render 'about/links', instance: InstancePresenter.new
+  context 'when signed out' do
+    before do
+      allow(view).to receive(:user_signed_in?).and_return(false)
+    end
 
-    expect(rendered).to have_content(I18n.t('about.get_started'))
-    expect(rendered).to have_content(I18n.t('auth.login'))
-  end
+    it 'shows get started link when registrations are allowed' do
+      render 'about/links', instance: double(open_registrations: true)
 
-  it 'shows sign in link when register closed' do
-    instance_presenter = double(:instance_presenter, open_registrations: false)
-    assign(:instance_presenter, instance_presenter)
-    allow(view).to receive(:user_signed_in?).and_return(false)
-    render
+      expect(rendered).to have_content(I18n.t('about.get_started'))
+      expect(rendered).to have_content(I18n.t('auth.login'))
+    end
 
-    expect(rendered).not_to have_content(I18n.t('about.get_started'))
-    expect(rendered).to have_content(I18n.t('auth.login'))
+    it 'hides get started link when registrations are closed' do
+      render 'about/links', instance: double(open_registrations: false)
+
+      expect(rendered).not_to have_content(I18n.t('about.get_started'))
+      expect(rendered).to have_content(I18n.t('auth.login'))
+    end
   end
 end