From 49767d20bdb7a486f93e0ef3b842eede362ff174 Mon Sep 17 00:00:00 2001
From: Claire <claire.github-309c@sitedethib.com>
Date: Sun, 23 Jul 2023 14:31:16 +0200
Subject: [PATCH] Fix glitch local settings navigation items not being proper
 buttons (#2320)

---
 .../features/local_settings/navigation/item/index.jsx       | 6 ++----
 .../flavours/glitch/styles/components/local_settings.scss   | 5 +++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx b/app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx
index d1f3512ed..a708f4209 100644
--- a/app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx
+++ b/app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx
@@ -58,16 +58,14 @@ export default class LocalSettingsPage extends PureComponent {
       </a>
     );
     else if (onNavigate) return (
-      <a
+      <button
         onClick={handleClick}
-        role='button'
-        tabIndex={0}
         className={finalClassName}
         title={title}
         aria-label={title}
       >
         {iconElem} <span>{title}</span>
-      </a>
+      </button>
     );
     else return null;
   }
diff --git a/app/javascript/flavours/glitch/styles/components/local_settings.scss b/app/javascript/flavours/glitch/styles/components/local_settings.scss
index cb0b401b4..48e41b2c2 100644
--- a/app/javascript/flavours/glitch/styles/components/local_settings.scss
+++ b/app/javascript/flavours/glitch/styles/components/local_settings.scss
@@ -56,11 +56,16 @@
   padding: 15px 20px;
   color: inherit;
   background: lighten($ui-secondary-color, 8%);
+  border: 0;
   border-bottom: 1px $ui-secondary-color solid;
   cursor: pointer;
   text-decoration: none;
   outline: none;
   transition: background 0.3s;
+  box-sizing: border-box;
+  width: 100%;
+  text-align: start;
+  font-size: inherit;
 
   .text-icon-button {
     color: inherit;