From fd37e2121ce9ea14494fdb5393ad5a3bf7ce5464 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:13:27 -0700 Subject: [PATCH 01/10] PR template rename --- .github/{PULL_REQUEST_TEMPLATE.md => pull_request_template.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{PULL_REQUEST_TEMPLATE.md => pull_request_template.md} (100%) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/pull_request_template.md similarity index 100% rename from .github/PULL_REQUEST_TEMPLATE.md rename to .github/pull_request_template.md From 7353747ca593901d9fbc5ec44e5aac5c638ad44b Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:25:32 -0700 Subject: [PATCH 02/10] Simplify PR template --- .github/pull_request_template.md | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index db42b51eb..b1bd09a8f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,6 @@ ---- -name: Bug Fix -about: Fix a bug or critical performance issue -title: 'Bug Fix: ' -labels: 'status: pending triage' ---- -#### Please check for duplicates or similar PRs before submitting this PR. + ## Does this PR close any issues? If so, link them below. ## Briefly describe the issue(s) fixed. + +## Screenshots/Videos From 88b35ce8c2c9db037aca5df03535eead0b38f659 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:37:19 -0700 Subject: [PATCH 03/10] Tweak Bug Report Template --- .github/ISSUE_TEMPLATE/bug.yml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml index ffbc02fbc..6be3f1245 100644 --- a/.github/ISSUE_TEMPLATE/bug.yml +++ b/.github/ISSUE_TEMPLATE/bug.yml @@ -1,5 +1,5 @@ name: Bug Report -description: Report a bug or an issue in the game +description: Report a bug or an issue in the game. labels: ["type: minor bug", "status: pending triage"] title: "Bug Report: " body: @@ -8,22 +8,23 @@ body: label: Issue Checklist options: - label: I have properly named the issue - - label: I looked in issues/discussions, if it has been previously reported + - label: I have checked the issues/discussions pages to see if the issue has been previously reported - type: dropdown attributes: label: What platform are you using? options: - - Itch.io - Windows - - Itch.io - MacOS - - Itch.io - Linux - Newgrounds (Web) + - Itch.io (Web) + - Itch.io (Downloadable Build) - Windows + - Itch.io (Downloadable Build) - MacOS + - Itch.io (Downloadable Build) - Linux validations: required: true - type: dropdown attributes: - label: If you were playing on a browser, which one were you using? + label: If you are playing on a browser, which one are you using? options: - Google Chrome - Microsoft Edge @@ -35,7 +36,7 @@ body: - type: input attributes: label: Version - description: What version were you using? + description: What version are you using? placeholder: ex. 0.4.1 validations: required: true @@ -46,7 +47,7 @@ body: - type: markdown attributes: - value: "### Please do not report issues from other engines. These must be reported in their repositories." + value: "### Please do not report issues from other engines. These must be reported in their respective repositories." - type: markdown attributes: From ac11e5238d75deb789aee096904577772faaf022 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:40:38 -0700 Subject: [PATCH 04/10] Tweak Crash Report Template --- .github/ISSUE_TEMPLATE/crash.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/crash.yml b/.github/ISSUE_TEMPLATE/crash.yml index 7c160244d..74d2d628f 100644 --- a/.github/ISSUE_TEMPLATE/crash.yml +++ b/.github/ISSUE_TEMPLATE/crash.yml @@ -1,5 +1,5 @@ name: Crash Report -description: Report a crash that occurred while playing. +description: Report a crash that occurred while playing the game. labels: ["type: major bug", "status: pending triage"] title: "Crash: " body: @@ -8,22 +8,23 @@ body: label: Issue Checklist options: - label: I have properly named the issue - - label: I looked in issues/discussions, if it has been previously reported + - label: I have checked the issues/discussions pages to see if the issue has been previously reported - type: dropdown attributes: label: What platform are you using? options: - - Itch.io - Windows - - Itch.io - MacOS - - Itch.io - Linux - Newgrounds (Web) + - Itch.io (Web) + - Itch.io (Downloadable Build) - Windows + - Itch.io (Downloadable Build) - MacOS + - Itch.io (Downloadable Build) - Linux validations: required: true - type: dropdown attributes: - label: If you were playing on a browser, which one were you using? + label: If you are playing on a browser, which one are you using? options: - Google Chrome - Microsoft Edge @@ -35,18 +36,18 @@ body: - type: input attributes: label: Version - description: What version were you using? + description: What version are you using? placeholder: ex. 0.4.1 validations: required: true - type: markdown attributes: - value: "## Describe the issue." + value: "## Describe your bug." - type: markdown attributes: - value: "### Please do not report issues from other engines. These must be reported in their repositories." + value: "### Please do not report issues from other engines. These must be reported in their respective repositories." - type: markdown attributes: From ce24a6f7a3d5bfcc3eee48193c1972c052922a94 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:42:25 -0700 Subject: [PATCH 05/10] Tweak Enhancement Template --- .github/ISSUE_TEMPLATE/enhancement.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/enhancement.yml b/.github/ISSUE_TEMPLATE/enhancement.yml index 327a91fec..c3ac345db 100644 --- a/.github/ISSUE_TEMPLATE/enhancement.yml +++ b/.github/ISSUE_TEMPLATE/enhancement.yml @@ -7,8 +7,8 @@ body: attributes: label: Issue Checklist options: - - label: I have properly named the issue - - label: I looked in issues/discussions, if it has been previously reported + - label: I have properly named the enhancement + - label: I have checked the issues/discussions pages to see if the enhancement has been previously suggested - type: textarea attributes: From 0f35618a1597e599c4ff1804baf716831d91c035 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:43:15 -0700 Subject: [PATCH 06/10] PR template tweak --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b1bd09a8f..8e8a45e19 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,4 +3,4 @@ ## Briefly describe the issue(s) fixed. -## Screenshots/Videos +## Include any relevant screenshots or videos. From ca5e08f967d3aa43a34895170b3c97aa04794cba Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:47:34 -0700 Subject: [PATCH 07/10] Specify crash log location --- .github/ISSUE_TEMPLATE/crash.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/crash.yml b/.github/ISSUE_TEMPLATE/crash.yml index 74d2d628f..7690e8308 100644 --- a/.github/ISSUE_TEMPLATE/crash.yml +++ b/.github/ISSUE_TEMPLATE/crash.yml @@ -65,6 +65,6 @@ body: - type: textarea attributes: - label: Crash Logs (can be found in the crash folder) + label: Crash logs (can be found in the logs folder where Funkin.exe is) validations: required: true From ffadce45e0901ec8ef9f19e5ac1b9047867fd790 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 18:50:12 -0700 Subject: [PATCH 08/10] More crash report tweaks --- .github/ISSUE_TEMPLATE/crash.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/crash.yml b/.github/ISSUE_TEMPLATE/crash.yml index 7690e8308..c5240495d 100644 --- a/.github/ISSUE_TEMPLATE/crash.yml +++ b/.github/ISSUE_TEMPLATE/crash.yml @@ -1,7 +1,7 @@ name: Crash Report description: Report a crash that occurred while playing the game. labels: ["type: major bug", "status: pending triage"] -title: "Crash: " +title: "Crash Report: " body: - type: checkboxes attributes: @@ -55,7 +55,7 @@ body: - type: textarea attributes: - label: Context (Provide images, videos, etc. of the crash happening) + label: Context (Provide screenshots or videos of the crash happening) - type: textarea attributes: From 6698ee6770aa2525c861d8966e259f4f62777dd1 Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 20:31:06 -0700 Subject: [PATCH 09/10] . --- .github/ISSUE_TEMPLATE/enhancement.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/enhancement.yml b/.github/ISSUE_TEMPLATE/enhancement.yml index c3ac345db..816e4a12b 100644 --- a/.github/ISSUE_TEMPLATE/enhancement.yml +++ b/.github/ISSUE_TEMPLATE/enhancement.yml @@ -1,5 +1,5 @@ name: Enhancement -description: Suggest a new feature +description: Suggest a new feature. labels: ["type: enhancement", "status: pending triage"] title: "Enhancement: " body: From 25a90d841980c29e4007ce12818c294db431557e Mon Sep 17 00:00:00 2001 From: Hundrec Date: Wed, 10 Jul 2024 20:33:12 -0700 Subject: [PATCH 10/10] Reword in crash report --- .github/ISSUE_TEMPLATE/crash.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/crash.yml b/.github/ISSUE_TEMPLATE/crash.yml index c5240495d..6fb7c9437 100644 --- a/.github/ISSUE_TEMPLATE/crash.yml +++ b/.github/ISSUE_TEMPLATE/crash.yml @@ -43,7 +43,7 @@ body: - type: markdown attributes: - value: "## Describe your bug." + value: "## Describe your issue." - type: markdown attributes: