From e6d1f97e0e17623d56fedf927ec927a53a6ef4bc Mon Sep 17 00:00:00 2001 From: regulad <52430642+regulad@users.noreply.github.com> Date: Wed, 3 Feb 2021 10:51:52 -0500 Subject: [PATCH 1/2] Update Issue Templates I had made some mistakes when I first submmited this PR as far as formatting and markdown goes. Similar to #327. --- .github/ISSUE_TEMPLATE/bug.md | 27 ++++++-------------- .github/ISSUE_TEMPLATE/enhancement.md | 4 +-- .github/ISSUE_TEMPLATE/question.md | 4 +-- .github/PULL_REQUEST_TEMPLATE/bug.md | 6 ++--- .github/PULL_REQUEST_TEMPLATE/enhancement.md | 4 +-- 5 files changed, 13 insertions(+), 32 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug.md b/.github/ISSUE_TEMPLATE/bug.md index 9eb93945f..cc4d5b11a 100644 --- a/.github/ISSUE_TEMPLATE/bug.md +++ b/.github/ISSUE_TEMPLATE/bug.md @@ -4,29 +4,18 @@ about: Report a bug or critical performance issue title: 'Bug Report: ' labels: bug --- +#### Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitting an issue. +### If you are playing the game in a browser, what site are you playing it from? +[Newgrounds](https://www.newgrounds.com/portal/view/770371) or [Itch.io](https://ninja-muffin24.itch.io/funkin)? Specify below. -# Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitting an issue. +### If you are playing the game in a browser, what browser are you using? +Chrome (or a Chromium based browser, i.e. Edge, Opera, etc.), Firefox, or Safari? Specify blow. -## Where are you playing the game? - -### Web -- [ ] [Newgrounds](https://www.newgrounds.com/portal/view/770371) -- [ ] [Itch.io](https://ninja-muffin24.itch.io/funkin) - -#### If you are using a web build, what browser are you using? -- [ ] Chrome, or a Chromium based broswer (Edge, Opera, etc.) -- [ ] Firefox, or a Gecko based broswer -- [ ] Safari -- [ ] Other, please specify: - -### Local -- [ ] Windows x86 -- [ ] Windows x86_64 -- [ ] Linux -- [ ] macOS +### If you are playing a downloaded version of the game, what operating system are you using? +Windows (`x86`), Windows (`x86_64`), Linux, or macOS? Specify below. ## What version of the game are you using? Look in the bottom left corner of the main menu. ## Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible. -## Please describe your issue. Provide extensive detail and images if possibe. +## Please describe your issue. Provide extensive detail and images if possible. diff --git a/.github/ISSUE_TEMPLATE/enhancement.md b/.github/ISSUE_TEMPLATE/enhancement.md index c86b1a39a..e1cc3ae0d 100644 --- a/.github/ISSUE_TEMPLATE/enhancement.md +++ b/.github/ISSUE_TEMPLATE/enhancement.md @@ -4,7 +4,5 @@ about: Suggest a new feature title: 'Enhancement: ' labels: enhancement --- - -# Please check for duplicates or similar issues before creating this issue. - +#### Please check for duplicates or similar issues before creating this issue. ## What is your suggestion, and why should it be implemented? diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md index 15f86824b..0adb3cc26 100644 --- a/.github/ISSUE_TEMPLATE/question.md +++ b/.github/ISSUE_TEMPLATE/question.md @@ -4,7 +4,5 @@ about: Ask a general question title: 'Question: ' labels: question --- - -# Please check for duplicates or similar issues before asking your question. - +#### Please check for duplicates or similar issues before asking your question. ## What is your question? diff --git a/.github/PULL_REQUEST_TEMPLATE/bug.md b/.github/PULL_REQUEST_TEMPLATE/bug.md index 70d795633..41914c5ed 100644 --- a/.github/PULL_REQUEST_TEMPLATE/bug.md +++ b/.github/PULL_REQUEST_TEMPLATE/bug.md @@ -4,9 +4,7 @@ about: Fix a bug or critical performance issue title: 'Bug Fix: ' labels: bug --- - -# Please check for duplicates or similar PRs before creating this issue. - +#### Please check for duplicates or similar PRs before creating this issue. ## Does this PR close any issue(s)? If so, link them below. -## Breifly describe the issue(s) fixed. +## Briefly describe the issue(s) fixed. diff --git a/.github/PULL_REQUEST_TEMPLATE/enhancement.md b/.github/PULL_REQUEST_TEMPLATE/enhancement.md index 6af15f1b6..e208deefe 100644 --- a/.github/PULL_REQUEST_TEMPLATE/enhancement.md +++ b/.github/PULL_REQUEST_TEMPLATE/enhancement.md @@ -4,9 +4,7 @@ about: Add a new feature title: 'Enhancement: ' labels: enhancement --- - -# Please check for duplicates or similar PRs before creating this issue. - +#### Please check for duplicates or similar PRs before creating this issue. ## Does this PR close any issue(s)? If so, link them below. ## What do your change(s) add, and why should they be implemented? From 47ed4f3c89e0bf82c26ffe10b6e7973361d41c13 Mon Sep 17 00:00:00 2001 From: Jan200101 Date: Fri, 5 Feb 2021 13:14:28 +0100 Subject: [PATCH 2/2] check if newgroups api key actually exists before creating core --- source/NGio.hx | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/source/NGio.hx b/source/NGio.hx index 96ced6257..0c2631b86 100644 --- a/source/NGio.hx +++ b/source/NGio.hx @@ -35,19 +35,22 @@ class NGio trace('INIT NOLOGIN'); GAME_VER = "v" + Application.current.meta.get('version'); - NG.create(api); - - new FlxTimer().start(2, function(tmr:FlxTimer) + if (api.length != 0) { - var call = NG.core.calls.app.getCurrentVersion(GAME_VER).addDataHandler(function(response:Response) - { - GAME_VER = response.result.data.current_version; - trace('CURRENT NG VERSION: ' + GAME_VER); - gotOnlineVer = true; - }); + NG.create(api); - call.send(); - }); + new FlxTimer().start(2, function(tmr:FlxTimer) + { + var call = NG.core.calls.app.getCurrentVersion(GAME_VER).addDataHandler(function(response:Response) + { + GAME_VER = response.result.data.current_version; + trace('CURRENT NG VERSION: ' + GAME_VER); + gotOnlineVer = true; + }); + + call.send(); + }); + } } public function new(api:String, encKey:String, ?sessionId:String)