From 2dad5953fd393bc3723a5452d8ef6723d5deedd2 Mon Sep 17 00:00:00 2001 From: EliteMasterEric Date: Mon, 11 Sep 2023 17:42:46 -0400 Subject: [PATCH] I hope someone got fired for that blunder. --- source/funkin/ui/debug/charting/ChartEditorState.hx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/source/funkin/ui/debug/charting/ChartEditorState.hx b/source/funkin/ui/debug/charting/ChartEditorState.hx index 0fe6909e7..2adc99569 100644 --- a/source/funkin/ui/debug/charting/ChartEditorState.hx +++ b/source/funkin/ui/debug/charting/ChartEditorState.hx @@ -2716,12 +2716,13 @@ class ChartEditorState extends HaxeUIState trace('Creating new Note... (${renderedNotes.members.length})'); noteSprite.parentState = this; - // Setting note data resets position relative to the grid so we fix that. - noteSprite.updateNotePosition(renderedNotes); - // The note sprite handles animation playback and positioning. noteSprite.noteData = noteData; + // Setting note data resets the position relative to the group! + // If we don't update the note position AFTER setting the note data, the note will be rendered offscreen at y=5000. + noteSprite.updateNotePosition(renderedNotes); + // Add hold notes that are now visible (and not already displayed). if (noteSprite.noteData != null && noteSprite.noteData.length > 0 && displayedHoldNoteData.indexOf(noteSprite.noteData) == -1) {