Minor tweaks to appearance; fixed hyperlinks

channel_completion.go

@@ -19,6 +19,7 @@ func completionUserEntry(s state.Store, u discord.User, g *discord.Guild) cchat.
 			return cchat.CompletionEntry{
 				Raw:       u.Mention(),
 				Text:      RenderMemberName(*m, *g),
+				Secondary: text.Rich{Content: u.Username + "#" + u.Discriminator},
 				IconURL:   u.AvatarURL(),
 			}
 		}
@@ -27,6 +28,7 @@ func completionUserEntry(s state.Store, u discord.User, g *discord.Guild) cchat.
 	return cchat.CompletionEntry{
 		Raw:       u.Mention(),
 		Text:      text.Rich{Content: u.Username},
+		Secondary: text.Rich{Content: u.Username + "#" + u.Discriminator},
 		IconURL:   u.AvatarURL(),
 	}
 }
@@ -75,6 +77,7 @@ func (ch *Channel) completeMentions(word string) (entries []cchat.CompletionEntr
 				entries = append(entries, cchat.CompletionEntry{
 					Raw:       u.Mention(),
 					Text:      text.Rich{Content: u.Username},
+					Secondary: text.Rich{Content: u.Username + "#" + u.Discriminator},
 					IconURL:   u.AvatarURL(),
 				})
 				if len(entries) >= MaxCompletion {
@@ -106,6 +109,7 @@ func (ch *Channel) completeMentions(word string) (entries []cchat.CompletionEntr
 			entries = append(entries, cchat.CompletionEntry{
 				Raw:       mem.User.Mention(),
 				Text:      RenderMemberName(mem, *g),
+				Secondary: text.Rich{Content: mem.User.Username + "#" + mem.User.Discriminator},
 				IconURL:   mem.User.AvatarURL(),
 			})
 			if len(entries) >= MaxCompletion {
@@ -180,6 +184,7 @@ func (ch *Channel) completeEmojis(word string) (entries []cchat.CompletionEntry)
 				entries = append(entries, cchat.CompletionEntry{
 					Raw:       emoji.String(),
 					Text:      text.Rich{Content: ":" + emoji.Name + ":"},
+					Secondary: text.Rich{Content: guild.Name},
 					IconURL:   urlutils.Sized(emoji.EmojiURL(), 32), // small
 					Image:     true,
 				})

segments/embed.go

@@ -17,10 +17,12 @@ var imageExts = []string{".jpg", ".jpeg", ".png", ".webp", ".gif"}
 func (r *TextRenderer) renderEmbeds(embeds []discord.Embed, m *discord.Message, s state.Store) {
 	for _, embed := range embeds {
 		r.startBlock()
-		r.buf.WriteString("---\n")
+		r.buf.WriteString("---")
+		r.ensureBreak()
 
 		r.renderEmbed(embed, m, s)
 
+		r.ensureBreak()
 		r.buf.WriteString("---") // render prepends newline already
 		r.endBlock()
 	}

segments/link.go

@@ -5,6 +5,11 @@ import (
 	"github.com/yuin/goldmark/ast"
 )
 
+// linkState is used for ast.Link segments.
+type linkState struct {
+	linkstack []int // stack of starting integers
+}
+
 type LinkSegment struct {
 	start, end int
 	url        string
@@ -13,17 +18,30 @@ type LinkSegment struct {
 var _ text.Linker = (*LinkSegment)(nil)
 
 func (r *TextRenderer) link(n *ast.Link, enter bool) ast.WalkStatus {
+	// If we're entering the link node, then add the starting point to the stack
+	// and move on.
 	if enter {
-		// Write the actual title.
+		r.lnks.linkstack = append(r.lnks.linkstack, r.buf.Len())
-		start, end := r.write(n.Title)
+		return ast.WalkContinue
+	}
 
-		// Close the segment.
+	// If there's nothing in the stack, then don't do anything. This shouldn't
+	// happen.
+	if len(r.lnks.linkstack) == 0 {
+		return ast.WalkContinue
+	}
+
+	// We're exiting the link node. Pop the segment off the stack.
+	ilast := len(r.lnks.linkstack) - 1
+	start := r.lnks.linkstack[ilast]
+	r.lnks.linkstack = r.lnks.linkstack[:ilast]
+
+	// Close the segment on enter false.
 	r.append(LinkSegment{
 		start,
-			end,
+		r.buf.Len(),
 		string(n.Destination),
 	})
-	}
 
 	return ast.WalkContinue
 }

segments/md.go

@@ -55,6 +55,7 @@ type TextRenderer struct {
 	src  []byte
 	segs []text.Segment
 	inls inlineState
+	lnks linkState
 
 	// these fields can be nil
 	msg   *discord.Message