Add in drone configuration with basic testing

.drone.yml

@@ -0,0 +1,17 @@
+kind: pipeline
+name: tests
+
+steps:
+    # Tests ordered from quickest to slowest so failed builds fail quickly
+  - name: minimum-test
+    image: rust:1
+    commands:
+      - cargo test --no-default-features --features scgi_srv
+  - name: scgi-test
+    image: rust:1
+    commands:
+      - cargo test --no-default-features --features scgi_srv,user_management_advanced,user_management_routes,serve_dir,ratelimiting
+  - name: gemini-test
+    image: rust:1
+    commands:
+      - cargo test --features user_management_advanced,user_management_routes,serve_dir,ratelimiting

Cargo.toml

@@ -58,6 +58,3 @@ required-features = ["serve_dir"]
 [[example]]
 name = "ratelimiting"
 required-features = ["ratelimiting"]
-
-[package.metadata.docs.rs]
-rustc-args = ["--cfg", "docsrs"]

src/cert.rs

@@ -26,7 +26,6 @@ use rustls::*;
 
 #[derive(Clone, Debug)]
 #[cfg(feature = "certgen")]
-#[cfg_attr(docsrs, doc(cfg(feature = "certgen")))]
 /// The mode to use for determining the domains to use for a new certificate.
 ///
 /// Used to configure a [`Server`] using [`set_certificate_generation_mode()`]
@@ -46,7 +45,6 @@ pub enum CertGenMode {
 }
 
 #[cfg(feature = "certgen")]
-#[cfg_attr(docsrs, doc(cfg(feature = "certgen")))]
 impl CertGenMode {
     /// Generate a new self-signed certificate
     ///

src/handling.rs

@@ -56,7 +56,6 @@ pub enum Handler {
     StaticHandler(Response),
 
     #[cfg(feature = "serve_dir")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "serve_dir")))]
     /// A handler that serves a directory, including a directory listing
     ///
     /// Most often created with [`From<PathBuf>`]
@@ -209,7 +208,6 @@ impl From<&Document> for Handler {
 }
 
 #[cfg(feature = "serve_dir")]
-#[doc(cfg(feature = "serve_dir"))]
 impl From<PathBuf> for Handler {
     /// Serve files from a directory
     ///

src/lib.rs

@@ -1,5 +1,4 @@
 #![warn(missing_docs)]
-#![feature(doc_cfg)]
 #![doc(html_logo_url = "https://raw.githubusercontent.com/twitter/twemoji/master/assets/svg/1f30c.svg")]
 //! Kochab is an ergonomic and intuitive library for quickly building highly functional
 //! and advanced Gemini applications on either SCGI or raw Gemini.
@@ -241,7 +240,6 @@ pub mod routing;
 #[cfg(feature = "ratelimiting")]
 mod ratelimiting;
 #[cfg(feature = "user_management")]
-#[doc(cfg(feature = "user_management"))]
 pub mod user_management;
 #[cfg(feature = "gemini_srv")]
 mod cert;
@@ -249,7 +247,6 @@ mod cert;
 #[cfg(feature="user_management")]
 use user_management::UserManager;
 #[cfg(feature = "certgen")]
-#[doc(cfg(feature = "certgen"))]
 pub use cert::CertGenMode;
 
 pub use uriparse::URIReference;
@@ -719,7 +716,6 @@ impl Server {
     }
 
     #[cfg(feature="user_management")]
-    #[doc(cfg(feature = "user_management"))]
     /// Sets the directory to store user data in
     ///
     /// This will only be used if a database is not provided with [`set_database()`].
@@ -733,7 +729,6 @@ impl Server {
     }
 
     #[cfg(feature="user_management")]
-    #[doc(cfg(feature = "user_management"))]
     /// Sets a specific database to use
     ///
     /// This opens to trees within the database, both namespaced to avoid collisions.
@@ -748,7 +743,6 @@ impl Server {
     }
 
     #[cfg(feature="certgen")]
-    #[doc(cfg(feature = "certgen"))]
     /// Determine where certificate config comes from, if generation is required
     ///
     /// If a certificate & keyfile are not available on the provided path, they can be
@@ -761,7 +755,6 @@ impl Server {
     }
 
     #[cfg(feature = "gemini_srv")]
-    #[doc(cfg(feature = "gemini_srv"))]
     /// Sets the directory that kochab should look for TLS certs and keys into
     ///
     /// Northstar will look for files called `cert.pem` and `key.pem` in the provided
@@ -778,7 +771,6 @@ impl Server {
     }
 
     #[cfg(feature = "gemini_srv")]
-    #[doc(cfg(feature = "gemini_srv"))]
     /// Set the path to the TLS certificate kochab will use
     ///
     /// This defaults to `cert/cert.pem`.
@@ -791,7 +783,6 @@ impl Server {
     }
 
     #[cfg(feature = "gemini_srv")]
-    #[doc(cfg(feature = "gemini_srv"))]
     /// Set the path to the ertificate key kochab will use
     ///
     /// This defaults to `cert/key.pem`.
@@ -877,7 +868,6 @@ impl Server {
     }
 
     #[cfg(feature="ratelimiting")]
-    #[doc(cfg(feature = "ratelimiting"))]
     /// Add a rate limit to a route
     ///
     /// The server will allow at most `burst` connections to any endpoints under this
@@ -1010,7 +1000,6 @@ impl Server {
     }
 
     #[cfg(feature = "scgi_srv")]
-    #[doc(cfg(feature = "scgi_srv"))]
     /// Start serving requests on a given unix socket
     ///
     /// Requires an address in the form of a path to bind to.  This is only available when

src/types/body.rs

@@ -27,7 +27,6 @@ pub enum Body {
 impl Body {
     /// Called by [`Response::rewrite_all`]
     #[cfg(feature="scgi_srv")]
-    #[cfg_attr(docsrs, doc(cfg(feature = "scgi_srv")))]
     pub (crate) async fn rewrite_all(&mut self, based_on: &crate::Request) -> std::io::Result<bool> {
         let bytes = match self {
             Self::Bytes(bytes) => {
@@ -102,7 +101,6 @@ impl<'a> From<&'a str> for Body {
 }
 
 #[cfg(feature="serve_dir")]
-#[cfg_attr(docsrs, doc(cfg(feature = "serve_dir")))]
 impl From<File> for Body {
     fn from(file: File) -> Self {
         Self::Reader(Box::new(file))

src/types/request.rs

@@ -212,7 +212,6 @@ impl Request {
     }
 
     #[cfg(feature="scgi_srv")]
-    #[doc(cfg(feature = "scgi_srv"))]
     /// View any headers sent by the SCGI client
     ///
     /// When an SCGI client delivers a request (e.g. when your gemini server sends a
@@ -289,7 +288,6 @@ impl Request {
     }
 
     #[cfg(feature="user_management")]
-    #[doc(cfg(feature = "user_management"))]
     /// Attempt to determine the user who sent this request
     ///
     /// May return a variant depending on if the client used a client certificate, and if
@@ -302,7 +300,6 @@ impl Request {
     }
 
     #[cfg(feature="user_management")]
-    #[doc(cfg(feature = "user_management"))]
     /// Expose the server's UserManager
     ///
     /// Can be used to query users, or directly access the database

src/user_management/mod.rs

@@ -23,7 +23,6 @@ mod manager;
 #[cfg(feature = "user_management_routes")]
 mod routes;
 #[cfg(feature = "user_management_routes")]
-#[doc(cfg(feature = "user_management_routes"))]
 pub use routes::UserManagementRoutes;
 pub use manager::UserManager;
 pub use user::User;
@@ -69,7 +68,6 @@ pub enum UserManagerError {
     DeserializeError(DeserializeError),
 
     #[cfg(feature = "user_management_advanced")]
-    #[doc(cfg(feature = "user_management_advanced"))]
     /// There was an error hashing or checking the user's password.
     ///
     /// This likely indicates database corruption, and should be handled in the same way
@@ -114,7 +112,6 @@ impl From<DeserializeError> for UserManagerError {
 }
 
 #[cfg(feature = "user_management_advanced")]
-#[doc(cfg(feature = "user_management_advanced"))]
 impl From<argon2::Error> for UserManagerError {
     fn from(error: argon2::Error) -> Self {
         Self::Argon2Error(error)
@@ -128,7 +125,6 @@ impl std::error::Error for UserManagerError {
             Self::DatabaseTransactionError(e) => Some(e),
             Self::DeserializeError(e) => Some(e),
             #[cfg(feature = "user_management_advanced")]
-            #[doc(cfg(feature = "user_management_advanced"))]
             Self::Argon2Error(e) => Some(e),
             _ => None
         }
@@ -149,7 +145,6 @@ impl std::fmt::Display for UserManagerError {
             Self::DeserializeError(e) =>
                 write!(f, "Recieved messy data from database, possible corruption: {}", e),
             #[cfg(feature = "user_management_advanced")]
-            #[doc(cfg(feature = "user_management_advanced"))]
             Self::Argon2Error(e) =>
                 write!(f, "Argon2 Error, likely malformed password hash, possible database corruption: {}", e),
         }

src/user_management/user.rs

@@ -164,7 +164,6 @@ impl NotSignedInUser {
     }
 
     #[cfg(feature = "user_management_advanced")]
-    #[doc(cfg(feature = "user_management_advanced"))]
     /// Attach this certificate to an existing user
     ///
     /// Try to add this certificate to another user using a username and password.  If
@@ -285,7 +284,6 @@ impl<UserData: Serialize + DeserializeOwned> RegisteredUser<UserData> {
     }
 
     #[cfg(feature = "user_management_advanced")]
-    #[doc(cfg(feature = "user_management_advanced"))]
     /// Check a password against the user's password hash
     ///
     /// # Errors
@@ -313,7 +311,6 @@ impl<UserData: Serialize + DeserializeOwned> RegisteredUser<UserData> {
     }
 
     #[cfg(feature = "user_management_advanced")]
-    #[doc(cfg(feature = "user_management_advanced"))]
     /// Set's the password for this user
     ///
     /// By default, users have no password, meaning the cannot add any certificates beyond
@@ -454,7 +451,6 @@ impl<UserData: Serialize + DeserializeOwned> RegisteredUser<UserData> {
     }
 
     #[cfg(feature = "user_management_advanced")]
-    #[doc(cfg(feature = "user_management_advanced"))]
     /// Check if the user has a password set
     ///
     /// Since authentication is done using client certificates, users aren't required to

src/util.rs

@@ -16,7 +16,6 @@ use crate::types::{Document, document::HeadingLevel::*};
 use crate::types::Response;
 
 #[cfg(feature="serve_dir")]
-#[doc(cfg(feature = "serve_dir"))]
 pub async fn serve_file<P: AsRef<Path>>(path: P, mime: &str) -> Response {
     let path = path.as_ref();
 
@@ -35,7 +34,6 @@ pub async fn serve_file<P: AsRef<Path>>(path: P, mime: &str) -> Response {
 }
 
 #[cfg(feature="serve_dir")]
-#[doc(cfg(feature = "serve_dir"))]
 pub async fn serve_dir<D: AsRef<Path>, P: AsRef<Path>>(dir: D, virtual_path: &[P]) -> Response {
     debug!("Dir: {}", dir.as_ref().display());
     let dir = dir.as_ref();
@@ -131,7 +129,6 @@ async fn serve_dir_listing<P: AsRef<Path>, B: AsRef<Path>>(path: P, virtual_path
 }
 
 #[cfg(feature="serve_dir")]
-#[doc(cfg(feature = "serve_dir"))]
 pub fn guess_mime_from_path<P: AsRef<Path>>(path: P) -> &'static str {
     let path = path.as_ref();
     let extension = path.extension().and_then(|s| s.to_str());