From 9c999609ef97907369723f76d70199f1f1583b1f Mon Sep 17 00:00:00 2001
From: Emii Tatsuo <emi@alchemi.dev>
Date: Sat, 28 Nov 2020 14:47:39 -0500
Subject: [PATCH] Accept strings in Document methods

A lot of the time users are using the document, it's in order to dynamically generate a page.  However, when dynamically generating a page, most of the time you're working with String's, not just &str's.  Currently, many Document methods only take an &str, which means that each time you call a method with something like the output from `format!()`, you need to add a `.as_str()`, which adds just a little bit of clutter.

This change makes it so that Document methods that previously took an `&str` can now take an `impl AsRef<str>`, which allows users to pass either an `&str` or a `String`.
---
 src/types/document.rs | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/types/document.rs b/src/types/document.rs
index d71c851..06d12bf 100644
--- a/src/types/document.rs
+++ b/src/types/document.rs
@@ -147,8 +147,9 @@ impl Document {
     ///
     /// assert_eq!(document.to_string(), "hello\n * world!\n");
     /// ```
-    pub fn add_text(&mut self, text: &str) -> &mut Self {
+    pub fn add_text(&mut self, text: impl AsRef<str>) -> &mut Self {
         let text = text
+            .as_ref()
             .lines()
             .map(Text::new_lossy)
             .map(Item::Text);
@@ -236,8 +237,8 @@ impl Document {
     ///
     /// assert_eq!(document.to_string(), "```\na\n b\n  c\n```\n");
     /// ```
-    pub fn add_preformatted(&mut self, preformatted_text: &str) -> &mut Self {
-        self.add_preformatted_with_alt("", preformatted_text)
+    pub fn add_preformatted(&mut self, preformatted_text: impl AsRef<str>) -> &mut Self {
+        self.add_preformatted_with_alt("", preformatted_text.as_ref())
     }
 
     /// Adds a block of preformatted text with an alt text.
@@ -257,9 +258,10 @@ impl Document {
     ///
     /// assert_eq!(document.to_string(), "```rust\nfn main() {\n}\n```\n");
     /// ```
-    pub fn add_preformatted_with_alt(&mut self, alt: &str, preformatted_text: &str) -> &mut Self {
-        let alt = AltText::new_lossy(alt);
+    pub fn add_preformatted_with_alt(&mut self, alt: impl AsRef<str>, preformatted_text: impl AsRef<str>) -> &mut Self {
+        let alt = AltText::new_lossy(alt.as_ref());
         let lines = preformatted_text
+            .as_ref()
             .lines()
             .map(PreformattedText::new_lossy)
             .collect();
@@ -318,8 +320,8 @@ impl Document {
     ///
     /// assert_eq!(document.to_string(), "* milk\n* eggs\n");
     /// ```
-    pub fn add_unordered_list_item(&mut self, text: &str) -> &mut Self {
-        let item = UnorderedListItem::new_lossy(text);
+    pub fn add_unordered_list_item(&mut self, text: impl AsRef<str>) -> &mut Self {
+        let item = UnorderedListItem::new_lossy(text.as_ref());
         let item = Item::UnorderedListItem(item);
 
         self.add_item(item);
@@ -340,8 +342,9 @@ impl Document {
     ///
     /// assert_eq!(document.to_string(), "> I think,\n> therefore I am\n");
     /// ```
-    pub fn add_quote(&mut self, text: &str) -> &mut Self {
+    pub fn add_quote(&mut self, text: impl AsRef<str>) -> &mut Self {
         let quote = text
+            .as_ref()
             .lines()
             .map(Quote::new_lossy)
             .map(Item::Quote);